use isCloseable condition for remember chat tab

FAForever · Jun 19, 2024 · 8f65a84 · 8f65a84
1 parent 2c8b770
commit 8f65a84
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 11 deletions.
diff --git a/src/main/java/com/faforever/client/chat/ChatController.java b/src/main/java/com/faforever/client/chat/ChatController.java
@@ -26,8 +26,6 @@
 @RequiredArgsConstructor
 public class ChatController extends NodeController<AnchorPane> {
 
-  public static String ADD_CHANNEL_TAB_ID = "_add_channel_tab_";
-
   private final ChatService chatService;
   private final UiService uiService;
   private final FxApplicationThreadExecutor fxApplicationThreadExecutor;
@@ -44,7 +42,6 @@ public class ChatController extends NodeController<AnchorPane> {
 
   public AnchorPane chatRoot;
   public TabPane tabPane;
-  public Tab addChannelTab;
   public Pane connectingProgressPane;
   public VBox noOpenTabsContainer;
   public TextField channelNameTextField;
@@ -55,14 +52,17 @@ public class ChatController extends NodeController<AnchorPane> {
   @Override
   protected void onInitialize() {
     super.onInitialize();
-    addChannelTab.setId(ADD_CHANNEL_TAB_ID);
     openedTabs = tabPane.getTabs();
 
     chatService.addChannelsListener(new WeakMapChangeListener<>(channelChangeListener));
     chatService.getChannels().forEach(this::onChannelJoined);
 
     chatService.connectionStateProperty().when(showing).subscribe(this::onConnectionStateChange);
-    tabPane.getSelectionModel().selectedItemProperty().subscribe(tab -> chatNavigation.setLastOpenedTabId(tab.getId()));
+    tabPane.getSelectionModel().selectedItemProperty().subscribe(tab -> {
+      if (tab.isClosable()) {
+        chatNavigation.setLastOpenedTabId(tab.getId());
+      }
+    });
   }
 
   private void onChannelLeft(ChatChannel chatChannel) {

diff --git a/src/main/java/com/faforever/client/chat/ChatNavigation.java b/src/main/java/com/faforever/client/chat/ChatNavigation.java
@@ -26,10 +26,6 @@ public String getLastOpenedTabId() {
   }
 
   public void setLastOpenedTabId(String tabId) {
-    if (ChatController.ADD_CHANNEL_TAB_ID.equals(tabId)) {
-      return;
-    }
-
     currentTabs.forEach(tab -> tab.setSelected(tab.getId().equals(tabId)));
   }
 

diff --git a/src/main/resources/theme/chat/chat.fxml b/src/main/resources/theme/chat/chat.fxml
@@ -14,7 +14,7 @@
     <children>
         <TabPane fx:id="tabPane" tabClosingPolicy="ALL_TABS" AnchorPane.bottomAnchor="0.0" AnchorPane.leftAnchor="0.0"
                  AnchorPane.rightAnchor="0.0" AnchorPane.topAnchor="0.0" visible="false">
-            <Tab fx:id="addChannelTab" text="+" closable="false">
+            <Tab text="+" closable="false">
                 <VBox fx:id="noOpenTabsContainer" alignment="CENTER" fillWidth="false">
                     <children>
                         <Label styleClass="h2" text="%chat.joinAChannel">

diff --git a/src/test/java/com/faforever/client/chat/ChatControllerTest.java b/src/test/java/com/faforever/client/chat/ChatControllerTest.java
@@ -69,7 +69,7 @@ private void setChannelsListener() {
   @Test
   public void testOnlyOneAddChannelTabAfterInitialized() {
     assertEquals(1, openedTabs.size());
-    assertEquals(ChatController.ADD_CHANNEL_TAB_ID, openedTabs.getFirst().getId());
+    assertFalse(openedTabs.getFirst().isClosable());
   }
 
   @Test