Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing the new replay container #3194

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Introducing the new replay container #3194

wants to merge 1 commit into from

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Jun 3, 2024 •
edited
Loading

Requires FAForever/faf-java-commons#151

To do:

  • Show the game options
  • Show the game version outside of the game options

@Garanas Garanas changed the title Replace the replay data parser with the new replay container First steps into using the new replay container Jun 3, 2024
@Garanas Garanas mentioned this pull request Jun 3, 2024
Merged
@Garanas Garanas changed the title First steps into using the new replay container Introducing the new replay container Jun 3, 2024
@Garanas Garanas marked this pull request as draft June 3, 2024 11:45
@Garanas
Copy link
Member Author

Garanas commented Jun 3, 2024

I don't entirely understand what testEnrich is testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Garanas