Skip to content

[No QA] Docs updates for E/A#97255 Canadian Multiple Tax Export template for CAD workspaces - #97741

Open
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-canadian-multiple-tax-export
Open

[No QA] Docs updates for E/A#97255 Canadian Multiple Tax Export template for CAD workspaces#97741
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-canadian-multiple-tax-export

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Docs updates for E/A#97255

PR #97255 adds the Canadian Multiple Tax Export template to the Export menu in New Expensify. The template appears in the default templates group for workspaces whose output currency is set to CAD, and produces a CSV that breaks out multiple tax amounts (such as GST and PST) into separate columns.

What changed in the docs

Added the Canadian Multiple Tax Export template to the "What export templates can I choose from?" list in both New Expensify export articles, noting it only appears on CAD workspaces:

  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md
  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md

The label Canadian Multiple Tax Export matches the exact UI string from src/languages/en.ts (export.multipleTaxExport).

Fixed Issues

$ #97231

@dukenv0307, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Nguyen Van Duc <dukenv0307@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 3, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#97255 Canadian Multiple Tax Export template for CAD workspaces [No QA] Docs updates for E/A#97255 Canadian Multiple Tax Export template for CAD workspaces Aug 4, 2026
@OSBotify

OSBotify commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@dukenv0307
dukenv0307 self-requested a review August 4, 2026 05:48
@dukenv0307

Copy link
Copy Markdown
Contributor

@MelvinBot Pls open the PR

@MelvinBot
MelvinBot marked this pull request as ready for review August 4, 2026 05:51
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now marked Ready for review.

dukenv0307, it's all yours whenever you'd like to review and merge.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single bullet describing the new Canadian Multiple Tax Export template to the "What export templates can I choose from?" list in two New Expensify articles (How-to-Export-Reports.md and How-to-Export-Expenses.md). The change is small, well-scoped, and consistent across both files.

Scores Summary

  • Readability: 9/10 - The added bullet is clear, concise, and follows the existing list pattern exactly. It states what the template does and when it appears in one tight, scannable sentence.
  • AI Readiness: 9/10 - Uses the full, exact feature name ("Canadian Multiple Tax Export"), includes a realistic qualifier (CAD workspaces), and slots into an existing task-based section. No metadata or heading changes were required, so nothing regresses. Only the diff is scored; existing frontmatter and headings are out of scope.
  • Style Compliance: 9/10 - The label matches the exact UI string (export.multipleTaxExport in src/languages/en.ts) and is bolded per Button/Section naming standards. Correctly uses the governed term Workspace Admin. Consistent phrasing across both files.

Key Findings

  • Positive: Feature label is verified against the source UI string and bolded correctly, satisfying the exact-UI-terminology rule.
  • Positive: Change is applied identically in both articles, keeping the two export docs in sync.
  • Positive: Single-workflow scope is preserved; the addition does not expand article scope or introduce cross-linking clutter.
  • Minor: Uses lowercase "workspaces" while the naming conventions treat Workspace as a proper product term. Consider "Workspaces" for consistency with the surrounding Workspace Admin usage.
  • Minor: "output currency" is described in prose but not bolded as a UI setting label; if it maps to an exact UI field, bolding would align with Section/Toggle reference rules.

Recommendations

  • Optional: Capitalize "Workspaces" in the new sentence to match Expensify terminology conventions.
  • Optional: Confirm whether "output currency" is an exact UI label and bold it if so.
  • No blocking issues. The change is accurate, well-formatted, and ready.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md - Added Canadian Multiple Tax Export bullet. Good.
  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md - Added Canadian Multiple Tax Export bullet. Good.

Note: Detailed line-by-line feedback has been provided as inline comments.

HelpDot Documentation Review

Overall Assessment

This PR adds a single bullet describing the new Canadian Multiple Tax Export template to the "What export templates can I choose from?" list in two New Expensify articles (How-to-Export-Reports.md and How-to-Export-Expenses.md). The change is small, well-scoped, and consistent across both files.

Scores Summary

  • Readability: 9/10 - The added bullet is clear, concise, and follows the existing list pattern exactly. It states what the template does and when it appears in one tight, scannable sentence.
  • AI Readiness: 9/10 - Uses the full, exact feature name ("Canadian Multiple Tax Export"), includes a realistic qualifier (CAD workspaces), and slots into an existing task-based section. No metadata or heading changes were required, so nothing regresses. Only the diff is scored; existing frontmatter and headings are out of scope.
  • Style Compliance: 9/10 - The label matches the exact UI string (export.multipleTaxExport in src/languages/en.ts) and is bolded per Button/Section naming standards. Correctly uses the governed term Workspace Admin. Consistent phrasing across both files.

Key Findings

  • Positive: Feature label is verified against the source UI string and bolded correctly, satisfying the exact-UI-terminology rule.
  • Positive: Change is applied identically in both articles, keeping the two export docs in sync.
  • Positive: Single-workflow scope is preserved; the addition does not expand article scope or introduce cross-linking clutter.
  • Minor: Uses lowercase "workspaces" while the naming conventions treat Workspace as a proper product term. Consider "Workspaces" for consistency with the surrounding Workspace Admin usage.
  • Minor: "output currency" is described in prose but not bolded as a UI setting label; if it maps to an exact UI field, bolding would align with Section/Toggle reference rules.

Recommendations

  • Optional: Capitalize "Workspaces" in the new sentence to match Expensify terminology conventions.
  • Optional: Confirm whether "output currency" is an exact UI label and bold it if so.
  • No blocking issues. The change is accurate, well-formatted, and ready.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md - Added Canadian Multiple Tax Export bullet. Good.
  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md - Added Canadian Multiple Tax Export bullet. Good.

Note: Detailed line-by-line feedback has been provided as inline comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants