Add Canadian Multiple Tax Export template to New Expensify for workspaces using CAD by dukenv0307 · Pull Request #97255 · Expensify/App

dukenv0307 · 2026-07-28T16:29:53Z

Explanation of Change

Fixed Issues

$ #97231
PROPOSAL:

Tests

Create a workspace, open its settings, set Output currency = CAD
Enable tax on the workspace; add at least one tax rate
Submit an expense with tax on that workspace (so the export has tax data)
Open the report containing that expense
Click the Export button (header/three-dot menu)
Verify Canadian Multiple Tax Export appears in the default templates group
Select it
Verify that: the export runs and the CSV (Concierge chat) has GST/PST columns + CURRENCY = CAD

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Create a workspace, open its settings, set Output currency = CAD
Enable tax on the workspace; add at least one tax rate
Submit an expense with tax on that workspace (so the export has tax data)
Open the report containing that expense
Click the Export button (header/three-dot menu)
Verify Canadian Multiple Tax Export appears in the default templates group
Select it
Verify that: the export runs and the CSV (Concierge chat) has GST/PST columns + CURRENCY = CAD

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-28.at.11.27.32.PM.mov

…aces using CAD

melvin-bot · 2026-07-28T16:29:58Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-07-28T16:30:17Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-28T16:35:38Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.81% <ø> (ø)`
src/libs/actions/Search.ts	`44.58% <50.00%> (+0.01%)`	⬆️
... and 41 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 336335be51

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-28T16:36:06Z

    }

+    // The Canadian Multiple Tax Export template is only relevant to workspaces that output in CAD, so it's hidden for every other currency
+    if (policy?.outputCurrency === CONST.CURRENCY.CAD) {


Include outputCurrency in exported-to policy projections

When this helper is reused by useExportedToFilterOptions, the policies come from exportedToPoliciesSelector, which currently projects only id, name, connections, and exportLayouts; it drops outputCurrency. For CAD workspaces this condition is therefore false in autocomplete/filter hydration, so users can export with Canadian Multiple Tax from the menu but cannot discover or preserve exported_to:"Canadian Multiple Tax Export" in search filters. Please include outputCurrency in that selector or avoid relying on a field those callers strip.

Useful? React with 👍 / 👎.

@dukenv0307 Could you please check this commetn?

@thelullabyy I fixed

thelullabyy · 2026-07-28T16:55:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: HybridApp

Screen.Recording.2026-08-02.at.18.03.34.mov

MacOS: Chrome / Safari

Screen.Recording.2026-08-02.at.17.43.32.mov

trjExpensify

Let's do it. 👍

NikkiWines · 2026-07-31T14:00:14Z

@thelullabyy are you able to review this? 🙇

thelullabyy · 2026-08-02T10:11:28Z

Reviewing now

NikkiWines

@dukenv0307 please fill out the QA section 🙇

dukenv0307 · 2026-08-03T16:13:02Z

@NikkiWines Thanks for pointing that out. I updated

NikkiWines

github-actions · 2026-08-03T22:10:37Z

🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-08-03T22:19:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97255.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-69db57483f4-ecf5fdc-17cdc47561047243cd04ca88af44b709fb187c85/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-69db574-ecf5fdc-5a5e360a19f2b569ba83f51efab35eb6cc07b776/index.html

Web 🕸️
https://97255.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-03T23:51:55Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.4.49-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-08-03T23:58:33Z

Help site review — docs update required ✅

This PR adds the Canadian Multiple Tax Export template to the Export menu in New Expensify (surfaced in the default templates group for workspaces whose output currency is set to CAD). Two New Expensify help articles list the available export templates and did not mention this new option, so they needed updating:

How-to-Export-Reports.md — "What export templates can I choose from?"
How-to-Export-Expenses.md — "What export templates can I choose from?"

I created a draft help site PR that adds the Canadian Multiple Tax Export template to both lists, noting it only appears on CAD workspaces:

Draft PR: #97741

I used the exact UI label Canadian Multiple Tax Export (verified against export.multipleTaxExport in src/languages/en.ts, which the PR added) per the naming conventions.

@dukenv0307, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review.

mitarachim · 2026-08-04T01:14:25Z

Deploy Blocker #97748 was identified to be related to this PR.

mitarachim · 2026-08-04T01:23:44Z

Deploy Blocker #97749 was identified to be related to this PR.

jponikarchuk · 2026-08-04T05:10:43Z

Deploy Blocker #97760 was identified to be related to this PR.

lanitochka17 · 2026-08-04T17:21:27Z

Deploy Blocker #97818 was identified to be related to this PR.

Add Canadian Multiple Tax Export template to New Expensify for worksp…

336335b

…aces using CAD

melvin-bot Bot assigned dukenv0307 Jul 28, 2026

dukenv0307 marked this pull request as ready for review July 28, 2026 16:30

dukenv0307 requested review from a team as code owners July 28, 2026 16:30

melvin-bot Bot requested review from thelullabyy and removed request for a team July 28, 2026 16:30

melvin-bot Bot requested review from trjExpensify and removed request for a team July 28, 2026 16:30

dukenv0307 requested a review from NikkiWines July 28, 2026 16:34

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Include outputCurrency in exported-to policy projections

2bbc0a4

trjExpensify approved these changes Jul 29, 2026

View reviewed changes

thelullabyy approved these changes Aug 2, 2026

View reviewed changes

NikkiWines requested changes Aug 3, 2026

View reviewed changes

NikkiWines approved these changes Aug 3, 2026

View reviewed changes

NikkiWines merged commit 69db574 into Expensify:main Aug 3, 2026
37 of 40 checks passed

github-actions Bot mentioned this pull request Aug 3, 2026

Investigate workflow job failing on main: typecheck / typecheck #97730

Closed

OSBotify mentioned this pull request Aug 3, 2026

Deploy Checklist: New Expensify 2026-08-03 #97732

Open

75 tasks

MelvinBot mentioned this pull request Aug 3, 2026

[No QA] Docs updates for E/A#97255 Canadian Multiple Tax Export template for CAD workspaces #97741

Open

applause-bot Bot mentioned this pull request Aug 4, 2026

Spend - Canadian Multiple Tax Export icon shows different icon in dropdown menu and Filters #97748

Open

7 tasks

applause-bot Bot mentioned this pull request Aug 4, 2026

Spend - Missing Canadian Multiple Tax Export when bulk selecting reports from CAD workspaces #97749

Open

7 tasks

mitarachim mentioned this pull request Aug 4, 2026

Add Canadian Multiple Tax Export template to New Expensify for workspaces using CAD #97231

Open

applause-bot Bot mentioned this pull request Aug 4, 2026

Spend - Canadian Multiple Tax Export is shown for non-CAD expense during bulk select #97760

Open

7 tasks

applause-bot Bot mentioned this pull request Aug 4, 2026

Expense-Tax amount is shown incorrectly in exported report. #97818

Open

7 tasks

Uh oh!

Conversation

dukenv0307 commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 28, 2026

Uh oh!

melvin-bot Bot commented Jul 28, 2026

Uh oh!

codecov Bot commented Jul 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines commented Jul 31, 2026

Uh oh!

thelullabyy commented Aug 2, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 3, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

OSBotify commented Aug 3, 2026

Uh oh!

MelvinBot commented Aug 3, 2026

Help site review — docs update required ✅

Uh oh!

mitarachim commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mitarachim commented Aug 4, 2026

Uh oh!

jponikarchuk commented Aug 4, 2026

Uh oh!

lanitochka17 commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dukenv0307 commented Jul 28, 2026 •

edited

Loading

codecov Bot commented Jul 28, 2026 •

edited by github-actions Bot

Loading

thelullabyy commented Jul 28, 2026 •

edited

Loading

mitarachim commented Aug 4, 2026 •

edited

Loading