Skip to content

fix: Account lists for credit card export appear on vendor bills #90593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 4 commits into from
May 20, 2026
+5 −5
Merged

fix: Account lists for credit card export appear on vendor bills #90593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b45b9c7
fix: Account lists for credit card export appear on vendor bills
ryntgh May 12, 2026
b4caace
Merge branch 'main' into issue/89148
ryntgh May 14, 2026
462efc9
Merge branch 'main' into issue/89148
ryntgh May 20, 2026
e686e9f
remove useCallback
ryntgh May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/pages/workspace/accounting/qbo/export/DynamicQuickbooksExportConfigurationPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import {useRoute} from '@react-navigation/native';
import React, {useCallback, useMemo} from 'react';
import React, {useMemo} from 'react';
import {View} from 'react-native';
import ConnectionLayout from '@components/ConnectionLayout';
import MenuItemWithTopDescription from '@components/MenuItemWithTopDescription';
import OfflineWithFeedback from '@components/OfflineWithFeedback';
import RenderHTML from '@components/RenderHTML';
import useDynamicBackPath from '@hooks/useDynamicBackPath';
import useLocalize from '@hooks/useLocalize';
import useOnyx from '@hooks/useOnyx';
import usePermissions from '@hooks/usePermissions';
Expand Down Expand Up @@ -48,9 +49,8 @@ function DynamicQuickbooksExportConfigurationPage({policy}: WithPolicyConnection
[qboConfig?.nonReimbursableExpensesExportDestination],
);

const goBack = useCallback(() => {
return goBackFromExportConnection(shouldShowVendorMenuItems, backTo);
}, [backTo, shouldShowVendorMenuItems]);
const dynamicBackPath = useDynamicBackPath(DYNAMIC_ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_EXPORT.path);
const goBack = () => goBackFromExportConnection(shouldShowVendorMenuItems, backTo, dynamicBackPath);

const menuItems = [
{
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/companyCards/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ function getExportMenuItem(
title: isDefaultTitle ? defaultCard : selectedAccount?.name,
exportType,
shouldShowMenuItem,
exportPageLink: createDynamicRoute(DYNAMIC_ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_EXPORT.path, basePath),
exportPageLink: createDynamicRoute(DYNAMIC_ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_EXPORT.path, backTo ?? basePath),
Comment thread
ryntgh marked this conversation as resolved.
Comment thread
ryntgh marked this conversation as resolved.
data: resultData.map((card) => ({
value: card.id,
text: card.name,
Expand Down
Loading