fix: update dark-contrast config

[truph01]

Explanation of Change

This PR fixes four bugs introduced by PR #85197 (High Contrast theme):

1. Invisible mentions in dark high-contrast mode ([Due for payment 2026-04-14] Theme - Highlighted search query and mention are not visible when high contrast mode is enabled #86339): The dark-contrast theme set mentionText to colors.blue600 but did not override mentionBG, which inherits colors.blue600 from the base dark theme. This made mention text and background the same color (#0164BF), rendering mentions invisible. Fixed by adding mentionText: colors.blue700, mentionBG: colors.blue100 to dark-contrast.ts:
   Result:

2. Enter key doesn't toggle high contrast switch ([Due for payment 2026-04-14] Preference - Unable to turn on the high contrast mode toggle using enter key #86346): The disableEnterShortcut guard in BaseSelectionList only checked for button and checkbox roles. When the Switch (role=switch) had focus inside the SelectionList footer, pressing Enter triggered the list's keyboard shortcut instead. Fixed by adding CONST.ROLE.SWITCH to disableEnterShortcut in BaseSelectionList.tsx

3. GBR badge ignores high contrast theme ([Due for payment 2026-04-14] Theme - High contrast theme is not applied on GBR on LHN #86349): badgeStrongText used hardcoded colors.white instead of a theme-aware variable. Fixed by changing it to theme.buttonSuccessText, which resolves to near-white in normal themes and dark green in high-contrast themes.

Result:

Fixed Issues

$ #79228 (Original issue)
$ #86339
$ #86346
$ #86349
PROPOSAL:

Tests

1. Enable dark mode and turn on high contrast toggle in Settings > Preferences > Theme
2. Go to a chat and type an @mention (e.g., @concierge) — verify the mention text is visible.
3. Navigate to Settings > Preferences > Theme, use Tab to focus the High Contrast toggle, press Enter — verify the toggle activates
4. With dark + high contrast enabled, check GBR badge text (Submit/Approve/Pay) on LHN entries — verify text uses high-contrast dark color instead of white

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include ""[No QA].""

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-31.at.01.24.34.mov

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Badge.tsx	100.00% <100.00%> (ø)
src/components/SelectionList/BaseSelectionList.tsx	65.45% <100.00%> (ø)
...ListWithSections/BaseSelectionListWithSections.tsx	93.90% <100.00%> (ø)
src/styles/index.ts	49.00% <ø> (ø)
src/styles/theme/themes/dark-contrast.ts	100.00% <ø> (ø)
... and 16 files with indirect coverage changes

[melvin-bot]

@dubielzyk-expensify @jayeshmangwani One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67c2b27dc0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[MelvinBot]

Hey truph01, here are a few suggestions and observations:

1. badgeStrongText → theme.buttonSuccessText coupling

Using theme.buttonSuccessText for badge text works today because both contexts need the same color values, but it creates a semantic coupling — if buttonSuccessText is ever adjusted for button-specific reasons, it would unexpectedly change badge text too. A more robust approach would be to introduce a dedicated theme key (e.g., badgeStrongTextColor) or use a more general theme variable. That said, this is a minor concern and may not be worth the added complexity for a follow-up fix — just something to be aware of.

2. Unit tests

The PR doesn't include any test files, but the author checklist mentions adding unit tests for bug fixes. The Enter key + switch fix in BaseSelectionList would be a good candidate for a test — verifying that pressing Enter when a role="switch" element is focused doesn't trigger the list's keyboard shortcut. This would help prevent the regression from being reintroduced.

3. Mention colors look good

The mentionText: blue700 + mentionBG: blue100 combo for dark-contrast effectively mirrors the light-contrast approach (which also uses blue700 text on blue100 background). The contrast ratio between #003C73 and #B0D9FF should be strong. The bright mention pills will stand out more on the dark background compared to standard dark theme, but that's consistent with the high-contrast accessibility goal.

4. Type rename is clean

Renaming ButtonOrCheckBoxRoles → InteractiveElementRoles is a good call — the new name is extensible and won't need to change if more interactive roles are added later.

Overall the changes are focused and address the issues well.

[dubielzyk-expensify]

Images look good. I'm gonna run a test build to test further 👍

[github-actions]

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

[dubielzyk-expensify]

We need to fix the green mention as it doesn't pass AA:

Let's make it green100 for background and green700 for text only in dark contrast mode.

[truph01]

We need to fix the green mention as it doesn't pass AA:

I updated. Result:

[truph01]

@jayeshmangwani Could you review this one?

[jayeshmangwani]

@truph01 highlighted part looks odd when mentioning the user.

[truph01]

@dubielzyk-expensify We've updated to mentionBG: colors.blue100 based on your comment. But it causes the problem:

@truph01 highlighted part looks odd when mentioning the user.

Do you think we need to update the text color here?

[jayeshmangwani]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

[jayeshmangwani]

@truph01 Everything looks good on the PR apart from this one comment #86680 (comment).

[rushatgabhane]

amazing!!

[dubielzyk-expensify]

@dubielzyk-expensify We've updated to mentionBG: colors.blue100 based on #79228 (comment). But it causes the problem:
Do you think we need to update the text color here?

Great find! Yes let's update it there too

[truph01]

Great find! Yes let's update it there too

@dubielzyk-expensify What should be updated here?

[dubielzyk-expensify]

Actually there's no easy fix there cause it's using a bit of a different pattern. Let's leave that one for now and I'll see if we can explore and do it as a follow-up

[jayeshmangwani]

Sounds good, let’s proceed with this PR.

[jayeshmangwani]

LGTM 🚀

[Valforte]

LGTM

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86680.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8e64ce1-9f1b0ad-0a79936beae2168a2513c412dee66ed2dd58adf2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8e64ce1-9f1b0ad-268bd62f525d16118b50b44206db6f5a28da862d/index.html

Web 🕸️
https://86680.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

🤖 I reviewed the changes in this PR and checked the help site documentation under docs/articles/.

Finding: The existing Account Settings article documents the Theme preferences but does not mention the High contrast mode toggle (introduced in #85197). While this PR itself is bug fixes, the underlying feature was never documented.

Help site PR created: #87000

Changes made:

• Added a new "How to enable high contrast mode" section with step-by-step instructions
• Updated the Theme summary bullet and FAQ to mention high contrast mode
• Added "high contrast mode" to article keywords for search discoverability
• Renamed ## Theme heading to ## How to change your theme to comply with HelpDot authoring guidelines (task-based headings)

Please mark the PR as "Ready for review" when it looks good.

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅