feat: date range filter UI and year picker fix (#81501) by btkcodedev · Pull Request #85313 · Expensify/App

btkcodedev · 2026-03-15T21:35:59Z

Explanation of Change

Added a new Range date filter option with dual side-by-side calendars for easier date range selection across all search date filters (Date, Approved, Paid, Submitted, Withdrawn, Posted, Exported).

Key Improvements

New Range Mode: Users can now select date ranges using two calendars displayed side-by-side (desktop) or stacked (mobile/sidebar)
Two-Date Validation: Enforces that both From and To dates must be selected when using Range mode, preventing incomplete date ranges
Consistent Display: Date ranges are now displayed as "Range: Jan 1, 2024 - Jan 31, 2024" entries in filter lists and titles
Auto-Detection: When both After and Before dates exist on page load, it automatically switches to Range mode for better UX
Responsive Layouts:
- Desktop popup: Side-by-side calendars with 660px popover width
- Sidebar filters: Vertically stacked calendars
- Mobile: Vertically stacked with full-screen view
Updated workflow: Custom Date and Custom Range are added for splitting one filter at a time

Fixed Issues

$ #81501
PROPOSAL: #81501 (comment)

Tests

Test Steps

Range Mode - Desktop Popup

Navigate to reports and click on date filter in the top filter bar
Click on the "Custom Range" option from the menu
Verify two calendars appear side-by-side in the popover (width ~660px)
Select a "From" date in the left calendar
Select a "To" date in the right calendar
Verify the range text appears below the calendars showing "Range: [date] - [date]"
Click "Apply" and verify the filter bar shows "[date] - [date]"

Range Mode - Sidebar Filters

Navigate to Reports > Filters options from top bar
Click on any date filter (Date, Approved, Paid, Submitted, Withdrawn, Posted, Exported)
Click on the "Custom Range" option from the menu
Verify two calendars are stacked vertically and responsive (one above the other)
Select dates in both calendars
Verify the range text appears showing "Range: [date] - [date]"
Click "Save" and "Apply results", verify with the range displayed matches the resulted items

Two-Date Validation

Open any date filter and select "Custom Range" mode
Select only a "From" date (leave "To" empty)
Click "Apply" or "Save"
Verify an error message appears: "Please select dates for both From and To"
Select a "To" date to complete the range
Click "Apply" or "Save" and verify it saves successfully

Individual After/Before Editing

Open Custom Date filter
Click "After" (not Range) and select a date
Click "Save"
Verify the filter displays as "After [date]"
Re-open the filter and click "Before"
Select a date and verify "Before" option is still accessible
Verify individual After/Before can still be set and edited separately
If range is applied the custom date filter is automatically discarded

Mobile/Narrow Layout

Resize browser to mobile width (<= 768px) or test on mobile device
Click on any date filter
Select "Custom Range" option
Verify calendars are stacked vertically in full-screen modal
Verify range text appears at bottom center of modal
Verify "Reset" and "Apply" buttons span full width at bottom

Android & iOS - Select year when keyboard is opened

Navigate to reports and click on the date filter in the top filter bar
Click on the "Custom Range" option from the menu
Change the year for the From or To calendars
When the keyboard appears, try to select another year from the list (without double-clicking)
Select a "From" date & select a "To" date in the calendars
Verify the range text appears below the calendars, showing "Range: [date] - [date]"
Click "Apply" and verify the filter is applied

Android - Search - Change dates multiple times

Navigate to reports and click on date filter in the top filter bar
Click on the "Custom Range" option from the menu
Select a "From" date and select other date multiple times
Verify that none of the dates disappear after multiple changes
Click "Apply" and verify the filter is applied

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Design verification

Verify that the designs are as given in the issue section

Range Mode - Desktop Popup

Navigate to reports and click on any date filter in the top filter bar
Click on the "Custom Range" option from the menu
Verify two calendars appear side-by-side in the popover (width ~660px)
Select a "From" date in the left calendar
Select a "To" date in the right calendar
Verify the range text appears below the calendars showing "Range: [date] - [date]"
Click "Apply" and verify the filter bar shows "Range: [date] - [date]"

Range Mode - Sidebar Filters

Navigate to Reports > Filters options from top bar
Click on any date filter (Date, Approved, Paid, Submitted, Withdrawn, Posted, Exported)
Click on the "Custom Range" option from the menu
Verify two calendars are stacked vertically and responsive (one above the other)
Select dates in both calendars
Verify the range text appears showing "Range: [date] - [date]"
Click "Save" and "Apply results", verify with the range displayed matches the resulted items

Two-Date Validation

Open any date filter and select "Custom Range" mode
Select only a "From" date (leave "To" empty)
Click "Apply" or "Save"
Verify an error message appears: "Please select dates for both From and To"
Select a "To" date to complete the range
Click "Apply" or "Save" and verify it saves successfully

Individual After/Before Editing

Open Custom Date filter
Click "After" (not Range) and select a date
Click "Save"
Verify the filter displays as "After [date]"
Re-open the filter and click "Before"
Select a date and verify "Before" option is still accessible
Verify individual After/Before can still be set and edited separately
If range is applied the custom date filter is automatically discarded

Mobile/Narrow Layout

Resize browser to mobile width (<= 768px) or test on mobile device
Click on any date filter
Select "Custom Range" option
Verify calendars are stacked vertically in full-screen modal
Verify range text appears at bottom center of modal
Verify "Reset" and "Apply" buttons span full width at bottom

Android & iOS - Select year when keyboard is opened

Navigate to reports and click on the date filter in the top filter bar
Click on the "Custom Range" option from the menu
Change the year for the From or To calendars
When the keyboard appears, try to select another year from the list (without double-clicking)
Select a "From" date & select a "To" date in the calendars
Verify the range text appears below the calendars, showing "Range: [date] - [date]"
Click "Apply" and verify the filter is applied

Android - Search - Change dates multiple times

Navigate to reports and click on date filter in the top filter bar
Click on the "Custom Range" option from the menu
Select a "From" date and select other date multiple times
Verify that none of the dates disappear after multiple changes
Click "Apply" and verify the filter is applied

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

SVID_20260401_222642_1.mp4

Android: mWeb Chrome

SVID_20260401_222422_1.mp4

iOS: Native

Screen.Recording.2026-04-01.at.10.37.21.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-04-01.at.10.41.55.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-01.at.9.55.53.PM.mov

melvin-bot · 2026-03-15T21:36:06Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-03-15T21:36:06Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-03-15T21:36:09Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

btkcodedev · 2026-03-15T21:38:28Z

Note for reviewer, IOS testing still in progress, I've done a small workaround for YearPicker autofocus, adding disableautofocus prop, will try for better fix parellely

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66ac605396

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-15T21:49:42Z

src/components/Search/FilterComponents/RangeDatePicker.tsx

+    const fromMaxDate = toValue ? new Date(toValue) : CONST.CALENDAR_PICKER.MAX_DATE;
+    const toMinDate = fromValue ? new Date(fromValue) : CONST.CALENDAR_PICKER.MIN_DATE;


Parse range boundary dates in local time

Using new Date(toValue) / new Date(fromValue) for yyyy-MM-dd strings makes the boundary dates UTC-based, which shifts them by one day in non-UTC timezones. Because these values are passed as maxDate/minDate to CalendarPicker, users west of UTC can be blocked from selecting the visible boundary day (for example, a selected to date can make the same calendar day unavailable in the from picker). This regression is specific to timezone context but affects core range selection behavior.

Useful? React with 👍 / 👎.

codecov · 2026-03-15T21:58:37Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/DatePicker/CalendarPicker/Day.tsx	`100.00% <100.00%> (ø)`
src/components/DatePicker/CalendarPicker/index.tsx	`82.47% <100.00%> (+0.18%)`	⬆️
src/components/Search/SearchLoadingSkeleton.tsx	`100.00% <100.00%> (ø)`
.../Search/SearchPageHeader/DatePickerFilterPopup.tsx	`0.00% <ø> (ø)`
...ts/Search/SearchPageHeader/useSearchActionsBar.tsx	`14.75% <ø> (ø)`
src/hooks/useSearchFilterSync.ts	`100.00% <100.00%> (ø)`
src/libs/DateUtils.ts	`68.21% <100.00%> (+0.94%)`	⬆️
src/types/form/SearchAdvancedFiltersForm.ts	`100.00% <ø> (ø)`
...mponents/Search/FilterDropdowns/DropdownButton.tsx	`93.33% <66.66%> (+0.22%)`	⬆️
src/CONST/index.ts	`93.65% <0.00%> (-1.52%)`	⬇️
... and 13 more
... and 15 files with indirect coverage changes

trjExpensify

Adding "Range" was an agreed product change in #convert. 👍

Pujan92 · 2026-03-18T12:38:02Z

src/components/DatePicker/CalendarPicker/Day.tsx

        <View
+            // Prevent Android from flattening this View, which can cause
+            // background color changes (day selection) to not trigger a native repaint.
+            collapsable={false}


I think this isn't required, inline styles for backgroundColor and text color are enough.

Pujan92 · 2026-03-18T12:38:16Z

src/components/DatePicker/CalendarPicker/Day.tsx

+                // Always provide an explicit backgroundColor so Android (which
+                // does not reset a property when the style changes to {})
+                // correctly transitions the selection highlight on every render.
+                {backgroundColor: selected ? theme.success : 'transparent'},


Suggested change

{backgroundColor: selected ? theme.success : 'transparent'},

{backgroundColor: selected ? theme.success : theme.transparent},

Pujan92 · 2026-03-18T12:49:09Z

src/components/DatePicker/CalendarPicker/YearPickerModal.tsx

            headerMessage,
            maxLength: 4,
            inputMode: CONST.INPUT_MODE.NUMERIC,
+            disableAutoFocus: Platform.OS === CONST.PLATFORM.ANDROID,


This doesn't look like a correct change, we need to fix it properly as it is working for other CalendarPicker places.

Working on it, still couldn't find the cause clearly

We need to use keyboardShouldPersistTaps="handled" for the ScrollView in the DateSelectPopup and DateFilterBase component as suggested by Melvin here. It works well.

Plz test and then we can revert this file(YearPickerModal) changes.

Pujan92 · 2026-03-18T18:16:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

am1.webm

Android: mWeb Chrome

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-03-25.at.22.04.16.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-03-25.at.22.33.33.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-25.at.21.59.56.mov

btkcodedev · 2026-03-29T08:13:29Z

Updated manual test steps
Merged with the latest main
Tested again end-to-end

Mac OS Chrome

Screen.Recording.2026-03-29.at.1.06.39.PM.mov

iOS

Screen.Recording.2026-03-29.at.1.37.44.PM.mov

Android

HnVideoEditor_2026_03_29_132548730.mp4

neil-marcellini

Thank you for your updates and applying my requested changes. It's looking pretty good, but there are still some merge conflicts.

Also, please update the manual test videos in the pull request description, showing that you tested the new cases for the previous deploy blockers. For android native it looks like the last video was from March 16.

neil-marcellini · 2026-03-30T18:38:42Z

src/components/Search/FilterDropdowns/DateSelectPopup/index.tsx

NAB: This is not a blocker for merging, but we should really extract some of the sub components to separate files and try to split out separate components as much as possible until each component is very easy to understand on its own and then ideally it's also easy to understand how they relate.

neil-marcellini · 2026-03-30T18:39:54Z

src/components/Search/FilterComponents/DatePresetFilterBase.tsx

+    /** Callback when date values change */
+    onDateValuesChange?: (dateValues: SearchDateValues) => void;
+
+    /** Backward-compatible alias for onDateValuesChange */
+    onDateValueChange?: (dateValues: SearchDateValues) => void;


Why do we need both of these. Can we consolidate into onDateValuesChange instead?

btkcodedev · 2026-04-01T17:19:04Z

Cleared conflicts
Tested again end-to-end and updated description videos
Updated all - MacOS Chrome, iOS native, iOS mWeb, Android native, and Android mWeb

neil-marcellini

I think it's good to go. Thanks!

github-actions · 2026-04-01T18:18:27Z

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-01T18:22:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85313.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e2e8c86-f008b41-412b9229de6b573e651138759dff3ac2d4ff8cda/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e2e8c86-f008b41-97936218245bc37c11414b1be85f4d5ddbfa54e2/index.html

Web 🕸️
https://85313.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-02T20:19:17Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-02T20:23:15Z

I reviewed the changes in this PR against the help site files under App/docs/articles.

Finding: The search operators article (docs/articles/new-expensify/reports-and-expenses/Using-search-operators.md) needed updates to document the new date range comparison syntax (>=, <=) that this PR introduces for date filters.

Changes made:

Updated the date: filter description to mention range comparisons (e.g., date>=2024-01-01 date<=2024-01-31)
Updated report date filters (submitted:, approved:, paid:, exported:) to mention range comparison support

PR created: #86992

No other help site articles required changes — the "Custom Range" UI feature is a new interaction pattern for existing date filter capabilities, and the other search-related articles (Export Expenses, Using Search on the Reports Page) don't cover filter syntax.

lanitochka17 · 2026-04-02T21:48:01Z

Deploy Blocker ##87017 was identified to be related to this PR.

mitarachim · 2026-04-02T21:53:39Z

Deploy Blocker #87019 was identified to be related to this PR.

mitarachim · 2026-04-02T22:03:30Z

Deploy Blocker #87020 was identified to be related to this PR.

vincdargento · 2026-04-02T22:26:16Z

Deploy Blocker #87026 was identified to be related to this PR.

btkcodedev · 2026-04-03T07:50:15Z

Follow-up PR: #87055

btkcodedev added 4 commits March 13, 2026 12:35

feat: date range filter UI and year picker fix (Expensify#81501)

1af8655

Merge branch 'main' into btkcodedev/81501RangeUI-V2

b81c113

fix Android view collapse and calendar selecting style issue

38bf708

fix: year selection autoselect on android

66ac605

btkcodedev requested review from a team as code owners March 15, 2026 21:36

melvin-bot bot requested review from Pujan92 and trjExpensify March 15, 2026 21:36

melvin-bot bot assigned btkcodedev Mar 15, 2026

melvin-bot bot requested review from a team and removed request for a team March 15, 2026 21:36

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 15, 2026 21:36

prettify

81ae58c

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

trjExpensify removed the request for review from joekaufmanexpensify March 16, 2026 10:36

trjExpensify previously approved these changes Mar 16, 2026

View reviewed changes

btkcodedev added 2 commits March 16, 2026 21:36

increase code coverage, utc time fix

237f56a

Merge branch 'main' into btkcodedev/81501RangeUI-V2

8fcd18d

Pujan92 reviewed Mar 18, 2026

View reviewed changes

Merge branch 'main' into btkcodedev/81501RangeUI-V2

bb90c1b

btkcodedev dismissed trjExpensify’s stale review via bb90c1b March 18, 2026 17:44

fix: yearpickermodal

b57910a

Merge branch 'main' into btkcodedev/81501RangeUI-V2

4bfe962

btkcodedev requested a review from neil-marcellini March 29, 2026 08:13

neil-marcellini requested changes Mar 30, 2026

View reviewed changes

btkcodedev added 4 commits April 1, 2026 16:39

Merge branch 'main' into btkcodedev/81501RangeUI-V2

2abd500

remove unwated prop

a02f4a0

split dateselectpopup into multiple files

5495b77

Merge branch 'main' into btkcodedev/81501RangeUI-V2

e7821fd

btkcodedev requested a review from neil-marcellini April 1, 2026 17:20

neil-marcellini approved these changes Apr 1, 2026

View reviewed changes

neil-marcellini merged commit e2e8c86 into Expensify:main Apr 1, 2026
36 checks passed

OSBotify mentioned this pull request Apr 2, 2026

Deploy Checklist: New Expensify 2026-04-02 #86989

Open

MelvinBot mentioned this pull request Apr 2, 2026

docs: document date range filter syntax in search operators article #86992

Open

2 tasks

lanitochka17 mentioned this pull request Apr 2, 2026

Reports- In Custom date range, "To" option is disabled #87017

Open

7 tasks

lanitochka17 mentioned this pull request Apr 2, 2026

[$250] Add Range UI filter for all date-type filters #81501

Open

mitarachim mentioned this pull request Apr 2, 2026

Reports - Custom range error message is not visible without scrolling #87019

Open

7 tasks

mitarachim mentioned this pull request Apr 2, 2026

Reports - Custom Range error message persists after selecting valid dates #87020

Open

7 tasks

vincdargento mentioned this pull request Apr 2, 2026

Reports - Dates are still applied after being resetted on "Custom Range" filter. #87026

Open

7 tasks

lanitochka17 mentioned this pull request Apr 2, 2026

Reports - Inconsistent behavior of "Range" text on "Date" exposed filter and "Filters" page #87028

Open

7 tasks

btkcodedev mentioned this pull request Apr 3, 2026

feat: Date Range filter follow up with fixes (#81501) #87055

Open

53 tasks

		const fromMaxDate = toValue ? new Date(toValue) : CONST.CALENDAR_PICKER.MAX_DATE;
		const toMinDate = fromValue ? new Date(fromValue) : CONST.CALENDAR_PICKER.MIN_DATE;

	{backgroundColor: selected ? theme.success : 'transparent'},
	{backgroundColor: selected ? theme.success : theme.transparent},

Conversation

btkcodedev commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Key Improvements

Fixed Issues

Tests

Test Steps

Range Mode - Desktop Popup

Range Mode - Sidebar Filters

Two-Date Validation

Individual After/Before Editing

Mobile/Narrow Layout

Android & iOS - Select year when keyboard is opened

Android - Search - Change dates multiple times

Offline tests

QA Steps

Design verification

Range Mode - Desktop Popup

Range Mode - Sidebar Filters

Two-Date Validation

Individual After/Before Editing

Mobile/Narrow Layout

Android & iOS - Select year when keyboard is opened

Android - Search - Change dates multiple times

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 15, 2026

Uh oh!

melvin-bot bot commented Mar 15, 2026

Uh oh!

melvin-bot bot commented Mar 15, 2026

Uh oh!

btkcodedev commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 15, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Pujan92 Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

btkcodedev commented Mar 29, 2026

Uh oh!

neil-marcellini left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

btkcodedev commented Mar 15, 2026 •

edited

Loading

codecov bot commented Mar 15, 2026 •

edited by github-actions bot

Loading

Pujan92 Mar 18, 2026 •

edited

Loading

Pujan92 commented Mar 18, 2026 •

edited

Loading

neil-marcellini left a comment •

edited

Loading