Skip to content

Conversation

@lakchote
Copy link
Contributor

@lakchote lakchote commented Nov 6, 2025

Reverts #74174 to fixes 2 blockers:

fixes #74385
fixes #74405
fixes #74406

BE returns correct data, but we have wrong Onyx data

QA

Can you retest the linked issues please?

@lakchote lakchote requested a review from a team as a code owner November 6, 2025 10:20
@melvin-bot melvin-bot bot requested a review from chuckdries November 6, 2025 10:21
@melvin-bot
Copy link

melvin-bot bot commented Nov 6, 2025

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team November 6, 2025 10:21
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #74452.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://74452.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lakchote
Copy link
Contributor Author

lakchote commented Nov 6, 2025

QA testing requested here: https://expensify.slack.com/archives/C9YU7BX5M/p1762425431947099

@lakchote lakchote mentioned this pull request Nov 6, 2025
54 tasks
@mountiny mountiny changed the title Revert "Bump onyx to 3.0.10" [CP Staging] Revert "Bump onyx to 3.0.10" Nov 6, 2025
@rlinoz
Copy link
Contributor

rlinoz commented Nov 6, 2025

This PR fixes this issue as well #74406

@mountiny mountiny merged commit 7352c6b into main Nov 6, 2025
35 of 40 checks passed
@mountiny mountiny deleted the revert-74174-bump-onyx-3.0.10 branch November 6, 2025 13:15
@melvin-bot
Copy link

melvin-bot bot commented Nov 6, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

mountiny commented Nov 6, 2025

Straight revert

OSBotify pushed a commit that referenced this pull request Nov 6, 2025
[CP Staging] Revert "Bump onyx to 3.0.10"

(cherry picked from commit 7352c6b)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 6, 2025
@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.45-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2025

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.46-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 7, 2025

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.46-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

5 participants