Bump onyx to 3.0.10 #74174
Merged
Bump onyx to 3.0.10 #74174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
dukenv0307
and removed request for
a team
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
JS00001
approved these changes
Nov 4, 2025
Contributor
|
@dukenv0307 Can you please take a look? @TMisiukiewicz Can you please include measurements of the perf difference on the flows as for any other performance improvement? It would be great to get an idea of how the individual changes improve the perf. Thanks! |
Contributor
@TMisiukiewicz, how can we verify it? |
Contributor
Author
|
@dukenv0307 I prepared something that should help you:
diff --git a/src/App.tsx b/src/App.tsx
index 9ed0e2bac6e..7e02a48c2aa 100644
--- a/src/App.tsx
+++ b/src/App.tsx
@@ -15,6 +15,7 @@ import CustomStatusBarAndBackground from './components/CustomStatusBarAndBackgro
import CustomStatusBarAndBackgroundContextProvider from './components/CustomStatusBarAndBackground/CustomStatusBarAndBackgroundContextProvider';
import {EnvironmentProvider} from './components/EnvironmentContext';
import ErrorBoundary from './components/ErrorBoundary';
+import FloatingReconnectButton from './components/FloatingReconnectButton';
import FullScreenBlockingViewContextProvider from './components/FullScreenBlockingViewContextProvider';
import FullScreenLoaderContextProvider from './components/FullScreenLoaderContext';
import HTMLEngineProvider from './components/HTMLEngineProvider';
@@ -136,6 +137,7 @@ function App() {
<Expensify />
</ColorSchemeWrapper>
</ErrorBoundary>
+ <FloatingReconnectButton />
<NavigationBar />
</ComposeProviders>
</View>
diff --git a/src/components/FloatingReconnectButton.tsx b/src/components/FloatingReconnectButton.tsx
new file mode 100644
index 00000000000..490976cda34
--- /dev/null
+++ b/src/components/FloatingReconnectButton.tsx
@@ -0,0 +1,43 @@
+import React from 'react';
+import {View} from 'react-native';
+import useTheme from '@hooks/useTheme';
+import useThemeStyles from '@hooks/useThemeStyles';
+import * as App from '@userActions/App';
+import * as Expensicons from './Icon/Expensicons';
+import Icon from './Icon';
+import {PressableWithFeedback} from './Pressable';
+import Text from './Text';
+
+function FloatingReconnectButton() {
+ const theme = useTheme();
+ const styles = useThemeStyles();
+
+ const handleReconnect = () => {
+ App.reconnectApp();
+ };
+
+ return (
+ <View style={[styles.floatingReconnectButton]}>
+ <PressableWithFeedback
+ onPress={handleReconnect}
+ style={[styles.floatingReconnectButtonInner]}
+ accessibilityLabel="Reconnect app"
+ role="button"
+ >
+ <Icon
+ src={Expensicons.Sync}
+ fill={theme.textLight}
+ width={20}
+ height={20}
+ />
+ <Text style={[styles.floatingReconnectButtonText]}>
+ Reconnect
+ </Text>
+ </PressableWithFeedback>
+ </View>
+ );
+}
+
+FloatingReconnectButton.displayName = 'FloatingReconnectButton';
+
+export default FloatingReconnectButton;
\ No newline at end of file
diff --git a/src/styles/index.ts b/src/styles/index.ts
index 6e0c1877a55..9bd780c9215 100644
--- a/src/styles/index.ts
+++ b/src/styles/index.ts
@@ -1609,6 +1609,37 @@ const staticStyles = (theme: ThemeColors) =>
zIndex: 10,
},
+ floatingReconnectButton: {
+ position: 'absolute',
+ top: 100,
+ right: 20,
+ zIndex: 10,
+ },
+
+ floatingReconnectButtonInner: {
+ backgroundColor: theme.success,
+ borderRadius: 20,
+ paddingHorizontal: 12,
+ paddingVertical: 8,
+ flexDirection: 'row',
+ alignItems: 'center',
+ shadowColor: theme.shadow,
+ shadowOffset: {
+ width: 0,
+ height: 2,
+ },
+ shadowOpacity: 0.25,
+ shadowRadius: 4,
+ elevation: 5,
+ },
+
+ floatingReconnectButtonText: {
+ color: theme.textLight,
+ fontSize: variables.fontSizeSmall,
+ marginLeft: 6,
+ fontWeight: 'bold',
+ },
+
topBarLabel: {
color: theme.text,
fontSize: variables.fontSizeXLarge,
Repeat on this branch. Remember to reinstall the dependencies when switching between branches Upload both files to https://kacper-mikolajczak.github.io/rcc/ and check the duration diff On my copilot account: |
Contributor
Author
|
@mountiny I added two measurements to the PR description, usage |
Contributor
|
Here's the result on my side 
|
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-05.at.21.25.40.movAndroid: mWeb ChromeScreen.Recording.2025-11-05.at.21.25.40.moviOS: HybridAppScreen.Recording.2025-11-05.at.21.28.20.moviOS: mWeb SafariScreen.Recording.2025-11-05.at.21.25.09.movMacOS: Chrome / SafariScreen.Recording.2025-11-05.at.21.29.38.movMacOS: DesktopScreen.Recording.2025-11-05.at.21.29.02.mov |
dukenv0307
approved these changes
Nov 5, 2025
Contributor
|
@mountiny looks faster based on this result. We're good to merge |
JS00001
approved these changes
Nov 5, 2025
Contributor
|
Hmm, I'm unable to rerun perf tests? |
Contributor
Author
|
IIRC They are disabled |
Contributor
|
I'm going to merge through the perf test failures then, since I cant restart them to get them to pass |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
79 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.2.45-0 🚀
|
Contributor
|
cc @JS00001 @dukenv0307 @TMisiukiewicz this causes 2 blockers for a feature that needs to be delived on prod (revert splits). See details in the revert PR: #74452 |
Contributor
|
🤔 What was the issue here? |
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This release includes:
Expensify/react-native-onyx#697
Expensify/react-native-onyx#693
Here are the measurements observed with this change:
Fixed Issues
$ #72679
PROPOSAL:
Tests
Offline tests
n/a
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov