-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix/73240 - The site header partially overlaps the typing indicator and composer error messages when the composer is focused and virtual keyboard is open #73630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmkt9
wants to merge
12
commits into
Expensify:main
Choose a base branch
from
dmkt9:fix/73240
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−16
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0336cb8
Fix - Site header overlaps error messages & typing indicator in Safar…
dmkt9 05452bb
Fix - Site header overlaps error messages & typing indicator in Safar…
dmkt9 7dfdfc8
Fix - Site header overlaps error messages & typing indicator in Safar…
dmkt9 60f28dc
Merge branch 'main' into fix/73240
dmkt9 270e4ad
Fix - Site header overlaps error messages & typing indicator in Safar…
dmkt9 085ed9e
fix lint
dmkt9 04d0344
Fix - Site header overlaps error messages & typing indicator in Safar…
dmkt9 d4ff196
Merge branch 'main' into fix/73240
dmkt9 385649e
Merge branch 'main' into fix/73240
dmkt9 959b545
Fix - Site header overlaps error messages & typing indicator in Safar…
dmkt9 1d483bf
Merge branch 'main' into fix/73240
dmkt9 3a8d2d6
Merge branch 'main' into fix/73240
dmkt9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 50 additions & 5 deletions
55
src/components/KeyboardAvoidingView/BaseKeyboardAvoidingView/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is affected on all pages which use KeyboardAvoidingView, right?
We should apply this only to report screen which has composer. Otherwise it will cause regressions on other pages on iOS 26 safari.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right.
When I created the PR, I reviewed all the styles applied to
BaseKeyboardAvoidingViewin the app, and none of them setpaddingBottom. So we don't need to worry about our PR overriding any existingpaddingBottom.That said, I still think we should apply the full padding, since in addition to the typing indicator and error messages, there's also the offline indicator. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though
paddingBottomprop is not passed in everyKeyboardAvoidingView,animatedStyleis always applied, isn't it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, but I'm not entirely sure what you mean. The regression has been minimized since we're not overriding any
paddingBottom. We still need to apply it globally because of the offline indicator.