-
Couldn't load subscription status.
- Fork 3.4k
Fix/73240 - The site header partially overlaps the typing indicator and composer error messages when the composer is focused and virtual keyboard is open #73630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
package.json
Outdated
| "react-plaid-link": "3.3.2", | ||
| "react-web-config": "^1.0.0", | ||
| "react-webcam": "^7.1.1", | ||
| "ua-parser-js": "^1.0.38", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, as I said, we should get device info from expensify-common, not here.
|
Please raise PR in expensify-common repo which supports iOS 26 detection |
Ah, my bad. I'll submit a PR soon. |
Explanation of Change
Fixed Issues
$ #73240
PROPOSAL: #73240 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Precondition: user signed in with account A on main testing iOS 26 device and account B on secondary
Open staging.new.expensify.com
Navigate to chat with account B
Tap on the composer to open the virtual keyboard
Start typing on the secondary device where account B is logged in
Look at the typing indicator text below the composer.
Paste the following text into the composer to trigger the error message:
[] Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean ma (creating task message with more than 100 characters)
Verify that the typing indicator and error messages should be fully visible and not overlapped by the site header when the composer is focused and virtual keyboard is open
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
The issue does not occur.
Android: mWeb Chrome
android.chrome.mp4
iOS: Native
The issue does not occur.
iOS: mWeb Safari
iOS 26:
ios.safari.26.mp4
iOS 18:
ios.safari.mp4
MacOS: Chrome / Safari
mac.safari.mp4
MacOS: Desktop
mac.desktop.mp4