-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Bump live markdown to 0.1.308 #72689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump live markdown to 0.1.308 #72689
Conversation
|
|
|
Spell check failing is not related to this PR 👍 |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
What's your ETA for review? @suneox |
I'll take a look at this one today |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-10-17.at.23.00.35.movAndroid: mWeb ChromeScreen.Recording.2025-10-17.at.22.50.55.moviOS: HybridAppScreen.Recording.2025-10-17.at.22.50.55.movScreenRecording_10-17-2025.23-22-04_1.MP4iOS: mWeb SafariScreen.Recording.2025-10-17.at.22.43.01.movMacOS: Chrome / SafariScreen.Recording.2025-10-17.at.22.40.17.movMacOS: DesktopScreen.Recording.2025-10-17.at.22.46.07.mov |
|
I’ve verified the markdown input in chat, task creation, expenses, workspace description, and private notes — everything still works correctly. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.35-0 🚀
|
|
HI @blazejkustra Do we have some specific tests for this? Also this is the same, right? https://github.com/Expensify/Mobile-Expensify/pull/13744 |
|
@izarutskaya we actually don't have any specific tests for live-markdown bumps
We migrated from
Yes, actually the other one should be marked as
Yes, that version only contains changes for the native side so iOS and Android tests should be enough 👍 |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.2.35-4 🚀
|
Explanation of Change
We are currently migrating E/App to Reanimated v4. As part of this effort we had to first migrate live-markdown here (LM supports both Reanimated v3 and v4 now).
Fixed Issues
$ #69504
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13744
Tests
Regression testing for the composer in the chat (it should work normally as before)
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop