Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : update scraping.py #45

Merged
merged 10 commits into from
Nov 9, 2023
Merged

feat : update scraping.py #45

merged 10 commits into from
Nov 9, 2023

Conversation

MineTime23
Copy link
Contributor

  1. 중복 방지 기능 구현
  • repeatCheck_rg, repeatCheck_rs : dict 활용

@MineTime23 MineTime23 requested a review from srlee056 November 8, 2023 13:50
srlee056
srlee056 requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@srlee056 srlee056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • local_code 주석처리되어있는게 맞나요?
  • updataDate.py 파일 아무 기능 없으면 삭제 해주세요
  • 최신버전 main을 지금 branch에 반영하여 (merge or rebase), scraping.py가 utils 폴더 안에 있는 구조로 업데이트 해주세요. 이 부분 이해 안되면 디엠 주세요.

@srlee056 srlee056 merged commit 905771b into main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srlee056 srlee056 srlee056 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MineTime23 @srlee056