bugfix: stopit import causes exception#1394
Open
reevesc7 wants to merge 4 commits intoEpistasisLab:devfrom
Open
bugfix: stopit import causes exception#1394reevesc7 wants to merge 4 commits intoEpistasisLab:devfrom
stopit import causes exception#1394reevesc7 wants to merge 4 commits intoEpistasisLab:devfrom
Conversation
Package build and PyPI deployment updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes importing
stopitby adding a fakepkg_resourcesmodule with aget_distribution()function.Where should the reviewer start?
tpot.utils.eval_utils.pyis the only changed file.How should this PR be tested?
The PR passed local tests and CI tests.
Any background context you want to provide?
This PR serves as an alternative to #1391, and only one of the two should be merged.
stopitis the only TPOT dependency which depends onpkg_resources.pkg_resourceshas been removed fromsetuptools, so importingstopitraises and exception.This PR creates a faux
pkg_resourcesmodule which contains aget_distribution()function (the only callstopitmakes).Under the hood, the faux module uses the modern dynamic package versioning solution
importlib.metadata.version().Because my branch was originally created from
EpistatisLab:main, this PR also merges those commits intoEpistasisLab:dev.What are the relevant issues?
#1391 is an alternative solution, which removes
stopitdependency entirely.Questions: