Remove stopit imports, references, and dependency#1391
Remove stopit imports, references, and dependency#1391reevesc7 wants to merge 4 commits intoEpistasisLab:devfrom
stopit imports, references, and dependency#1391Conversation
Package build and PyPI deployment updates
|
I have changed this PR's base branch to |
|
As another alternative solution to removing
This is not a nice solution, as Additionally, I have opened PR #1394, as an additional alternate solution which tricks |
What does this PR do?
This PR removes
stopitas a dependency and all (non-archived) references to it.Removed code references include
tpot.utils.eval_utils.optimize_objective()andtpot.utils.eval_utils.parallel_optimize_objective().Where should the reviewer start?
tpot/utils/eval_utils.pypyproject.tomlREADME.mdHow should this PR be tested?
A fresh install and standard tests may be appropriate to validate that the dependencies resolve properly.
The removed references to
stopitwere not referenced anywhere else within TPOT, but their removal would cause incompatibilities with any external scripts callingtpot.utils.eval_utils.optimize_objective()ortpot.utils.eval_utils.parallel_optimize_objective()....Maybe a deprecation warning would be appropriate, but as I describe below, there was already a deprecation warning being printed related to these functions.
Any background context you want to provide?
stopitimportspkg_resources, which was deprecated and is now removed.For some time,
pkg_resourcesprinted a deprecation warning stating that the module would be removed in the near future.That future has come, and now fresh installations may no longer function due to
stopitstill attempting to importpkg_resources.In fact, I discovered that
pkg_resourceshas been removed when freshly installing TPOT to make a different pull request.Unfortunately,
stopitis no longer maintained.The last update to its repository occurred 3 years ago.
The fix for the
pkg_resourcesissue is simple, and thestopitrepository has the fix waiting in a pull request.However, the request has remained open for a year and a half.
Given that
stopitis unlikely to regain functionality in the near future and that the TPOT internals do not utilize the module, I figured it would be best to remove the dependency.Alternatively, spraakbanken/stopit2 is a fork of
stopitwhich implements thepkg_resourcesfix.If maintainers desire to keep
stopit-like functionality within TPOT,stopit2may be a fitting choice.What are the relevant issues?
None that I found during a quick search.
EDIT: PR #1394 is an alternate solution, and either this PR or that one should be merged.
Questions:
stopit