feat: greedy loop to batch #1425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/loop_batch
branch
from
fe7ec4a to
66bd10b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
EnzymeJAX Benchmarks
| Benchmark suite | Current: 9c36971 | Previous: fcf54c5 | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.000004363031999673695 s |
0.000004405523999594152 s |
0.99 |
scatter_sum / JaXPipe / cpu / Primal |
0.000004365552996750921 s |
0.000004346182988956571 s |
1.00 |
scatter_sum / JaX / tpu / Primal |
0.0001437498921994 s |
0.0001421422843006 s |
1.01 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001381131653091 s |
0.0001422737602959 s |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
avik-pal
force-pushed
the
ap/loop_batch
branch
2 times, most recently
from
d4dca64 to
82364c8
Compare
avik-pal
force-pushed
the
ap/while_noop
branch
from
68b2367 to
37e44ff
Compare
avik-pal
force-pushed
the
ap/loop_batch
branch
from
e7527f8 to
2341aa3
Compare
avik-pal
force-pushed
the
ap/while_noop
branch
from
efaec18 to
fc223de
Compare
avik-pal
force-pushed
the
ap/loop_batch
branch
3 times, most recently
from
2330f4c to
16dc65c
Compare
avik-pal
force-pushed
the
ap/while_noop
branch
2 times, most recently
from
f0beb10 to
e358839
Compare
avik-pal
force-pushed
the
ap/loop_batch
branch
from
16dc65c to
f3f29e2
Compare
avik-pal
force-pushed
the
ap/loop_batch
branch
3 times, most recently
from
6464414 to
80f512f
Compare
avik-pal
force-pushed
the
ap/loop_batch
branch
3 times, most recently
from
7f8be5d to
7c02b16
Compare
avik-pal
force-pushed
the
ap/loop_batch
branch
from
7c02b16 to
af7bc5f
Compare
avik-pal
force-pushed
the
ap/loop_batch
branch
4 times, most recently
from
0fac8b6 to
0b6908c
Compare
|
Mostly ready except some minor optimizations. Needs #1513 which folds loops more aggressively |
avik-pal
force-pushed
the
ap/loop_batch
branch
3 times, most recently
from
a80f499 to
16a0dfc
Compare
avik-pal
force-pushed
the
ap/loop_batch
branch
2 times, most recently
from
8778889 to
f53e57d
Compare
feat: support non-constant extra indices fix: only emit new ops if sure feat: propagate bounds and eliminate noops chore: run fmt feat: check for dynamic_slices feat: unary elementwise working chore: comments feat: clear out unwanted no-ops from loop body feat: elementwise ops are completely supported chore: add a note fix: bad rebase feat: generalize index handling test: elementwise loop fission refactor: support dynamicsliceop feat: sliceinfo generalize feat: lift ops by batch op feat: run batching pass feat: generalize handling for non-reshape case
avik-pal
force-pushed
the
ap/loop_batch
branch
from
897f7f0 to
bac3366
Compare
wsmoses
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #851