Skip to content

Commit 82364c8

Browse files
committed
chore: add a note
1 parent 740aff6 commit 82364c8

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/enzyme_ad/jax/Passes/AutoBatching.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -942,6 +942,8 @@ int64_t GreedyWhileLoopBatchFission::isDynamicSliceValidForBatching(
942942
auto operand = sliceOp.getOperand();
943943
auto operandShape = cast<RankedTensorType>(operand.getType()).getShape();
944944

945+
// TODO: it doesn't need to be in the parent block, rather it needs to be
946+
// accessible from the parent block
945947
if (operand.getParentBlock() != parentBlock)
946948
return -1;
947949

src/enzyme_ad/jax/Passes/EnzymeHLOOpt.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23331,6 +23331,7 @@ struct DynamicPadToPad
2333123331
for (auto value : values)
2333223332
denseValues.push_back(value.getSExtValue());
2333323333
return DenseI64ArrayAttr::get(attr.getContext(), denseValues);
23334+
}
2333423335
};
2333523336

2333623337
struct RemoveNoOpsFromWhileLoop

0 commit comments

Comments
 (0)