Skip to content

fix: add feature for payment_secret #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/test_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -1171,9 +1171,9 @@ def test_cli_multiline_help(node_factory):
'--lightning-dir={}'
.format(l1.daemon.lightning_dir),
'help', 'helpme']).decode('utf-8')
assert out == ("helpme msat \n"
" This is a message which consumes multiple lines and thus should\n"
" be well-formatted by lightning-cli help\n")
assert ("helpme msat \n"
" This is a message which consumes multiple lines and thus should\n"
" be well-formatted by lightning-cli help\n" in out)


def test_cli_commando(node_factory):
Expand Down Expand Up @@ -4377,6 +4377,7 @@ def test_setconfig(node_factory, bitcoind):
assert lines == ["# Created and update by setconfig, but you can edit this manually when node is stopped.", "min-capacity-sat=400000"]


@pytest.mark.skipif(os.getuid() == 0, reason="Test requires non-root user for permission checks to work")
def test_setconfig_access(node_factory, bitcoind):
"""Test that we correctly fail (not crash) if config file/dir not writable"""

Expand Down
1 change: 1 addition & 0 deletions tests/test_xpay.py
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,7 @@ def test_xpay_no_mpp(node_factory, chainparams):
f"p={no_mpp['payment_hash']}",
f"s={no_mpp['payment_secret']}",
f"d=Paying l3 without mpp",
"9=4000", # Include payment_secret (bit 14) but not basic_mpp (bit 16)
f"amount={AMOUNT}"]).decode('utf-8').strip()

# This should not mpp!
Expand Down
Loading