Skip to content

fix: add feature for payment_secret #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

king-11
Copy link
Contributor

@king-11 king-11 commented Jun 8, 2025

  • payment_secret bit is a required feature bit that should always be set for bolt11.
  • make test_cli_multiline_help test's assert more flexible given extra sentences get printed while running the test in minimzed (docker images) environment.

Changelog-None: test fix to align with specification

Important

25.05 FREEZE MAY 05TH: Non-bugfix PRs not ready by this date will wait for 25.08.

RC1 is scheduled on May 12th, RC2 on May 16th, ...

The final release is on MAY 20TH.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@king-11
Copy link
Contributor Author

king-11 commented Jun 8, 2025

I am wondering if bolt11-cli should always set this bit or not 🤔

@king-11 king-11 force-pushed the king-11/payment_secret_support branch from 02001da to 271a660 Compare June 8, 2025 04:01
king-11 added 2 commits June 10, 2025 07:50
payment_secret bit is a required feature bit that should always be set for bolt11

Changelog-None: Align test with specification
running the test on minimized environments (docker images) prints additional lines which fails the test.

Given me only want to ensure that formatting and content are correct we can use `in` instead of extact match
@king-11 king-11 force-pushed the king-11/payment_secret_support branch from ed3e971 to a3feab2 Compare June 10, 2025 02:20
chmod works only for non-root user we should skip the test in root environments as it won’t pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant