fix: add feature for payment_secret #8330
Open
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am wondering if |
king-11
force-pushed
the
king-11/payment_secret_support
branch
2 times, most recently
from
ed3e971 to
a3feab2
Compare
payment_secret bit is a required feature bit that should always be set for bolt11 Changelog-None: Align test with specification
running the test on minimized environments (docker images) prints additional lines which fails the test. Given me only want to ensure that formatting and content are correct we can use `in` instead of extact match
chmod works only for non-root user we should skip the test in root environments as it won’t pass
king-11
force-pushed
the
king-11/payment_secret_support
branch
from
3e40010 to
8584808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_cli_multiline_helptest's assert more flexible given extra sentences get printed while running the test in minimzed (docker images) environment.Changelog-None: test fix to align with specification
Important
25.05 FREEZE MAY 05TH: Non-bugfix PRs not ready by this date will wait for 25.08.
RC1 is scheduled on May 12th, RC2 on May 16th, ...
The final release is on MAY 20TH.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: