Прошу проверить ДЗ1 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.util.Random; | ||
|
|
||
| public class JustDoIt { | ||
| public JustDoIt() { |
| Lesson1.Actions[] actions = new Lesson1.Actions[3]; | ||
| int distance = rand.nextInt(10); | ||
| int heigth = rand.nextInt(10); | ||
| actions[0] = new Lesson1.Human("Peter", distance, heigth); |
There was a problem hiding this comment.
классы можно импортировать, чтобы не дергать Lesson1.Human
| if (!result) { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
отличное решение. Вы догадались что у класса, символизирующего препятствие должен быть один метод, который будет переопределен в конкретной реализации. Пока лучшее решение
| } else { | ||
| barriers[i] = new Lesson1.Wall(i + 1 + " is Wall", distance); | ||
| } | ||
| } |
There was a problem hiding this comment.
по организации кода замечание - метод main у нас должен отражать соревнование. Поготовка данных тут занимает больше места чем непосредственно решение, можно вынести в отдельные методы
generateBarriers, generateParticipants
dmitry-sviridov
approved these changes
May 17, 2021
Откорректировала по замечаниям - не смогла только по барьерам
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.