-
Notifications
You must be signed in to change notification settings - Fork 21
Workspace/open3d fix latest #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deepanaishtaweera
wants to merge
9
commits into
main
Choose a base branch
from
workspace/open3d_fix_latest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
27f729d
Enhance Dockerfile and setup scripts for architecture-specific instal…
deepanaishtaweera 31af84e
Refactor CMake version check in setup-open3d-slam.sh for source builds
deepanaishtaweera f0c2f41
Fix dockerfile
deepanaishtaweera 95879a7
Update scripts/setup/setup-open3d-slam.sh
deepanaishtaweera 14554d5
Update Dockerfile to improve architecture-specific CMake message.
deepanaishtaweera 9915dd5
fix dockerfile
deepanaishtaweera f6b25cb
revert and install cmake in the docker build
deepanaishtaweera 531c42b
Merge branch 'main' into workspace/open3d_fix_latest
deepanaishtaweera ba7984d
Merge branch 'main' into workspace/open3d_fix_latest
deepanaishtaweera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,11 +52,23 @@ if [ "$EUID" -ne 0 ]; then | |
exit 1 | ||
fi | ||
|
||
# Determine system architecture | ||
readonly ARCH=$(uname -m) | ||
if [[ "$ARCH" == "x86_64" ]]; then | ||
readonly INSTALL_METHOD="ppa" | ||
elif [[ "$ARCH" == "aarch64" ]] || [[ "$ARCH" == "arm64" ]]; then | ||
readonly INSTALL_METHOD="source" | ||
else | ||
echo "ERROR: Unsupported architecture: $ARCH" | ||
echo "This script supports x86_64 (AMD64) and aarch64/arm64 (ARM64)" | ||
exit 1 | ||
fi | ||
|
||
# Set the target user | ||
USER="robotx" | ||
USER_HOME="/home/${USER}" | ||
|
||
echo "Setting up robot host system..." | ||
echo "Setting up robot host system on $ARCH architecture..." | ||
|
||
# Get the workspace root directory | ||
ROOT=$(dirname $(dirname $(dirname $(readlink -f $0)))) | ||
|
@@ -159,8 +171,13 @@ ${ROOT}/scripts/setup/setup-fzf.sh 0.52.1 | |
|
||
# Install ROS2 and Graph MSF only if --nuc flag is set | ||
if [ "$IS_NUC" = true ]; then | ||
# Install CMake | ||
${ROOT}/scripts/setup/setup-cmake.sh | ||
# Install CMake only for ARM64 builds (needed for Open3D source build) | ||
if [[ "$INSTALL_METHOD" == "source" ]]; then | ||
echo "Upgrading CMake for ARM64 build..." | ||
${ROOT}/scripts/setup/setup-cmake.sh | ||
else | ||
echo "Using default CMake for AMD64 build..." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] Hardcoding "AMD64" may confuse readers since Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
fi | ||
|
||
# Install Open3d SLAM | ||
${ROOT}/scripts/setup/setup-open3d-slam.sh | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Both setup scripts reimplement architecture detection. Consider extracting this into a shared helper or common script to reduce duplication.
Copilot uses AI. Check for mistakes.