Workspace/open3d fix latest #33
Conversation
…lations - Update Dockerfile to conditionally install CMake only for ARM64 builds, improving compatibility for Open3D source builds. - Modify setup-open3d-slam.sh to determine installation method based on system architecture, supporting both PPA for AMD64 and source for ARM64. - Adjust setup-robot-host.sh to reflect architecture-specific CMake installation, ensuring proper setup for different environments.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances ARM64 (aarch64/arm64) support by detecting the system architecture in setup scripts and choosing appropriate installation methods for CMake and Open3D, and updates the Dockerfile to apply the same logic.
- Add
ARCHdetection andINSTALL_METHODvariables insetup-robot-host.shandsetup-open3d-slam.sh - Conditionally upgrade or skip CMake based on architecture (source build for ARM64, default for x86_64)
- Switch Open3D installation to PPA for AMD64 and source build for ARM64, and mirror CMake logic in Dockerfile
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/setup/setup-robot-host.sh | Added architecture detection and conditional CMake installation |
| scripts/setup/setup-open3d-slam.sh | Added arch-specific CMake checks and Open3D install paths (PPA vs source) |
| .github/docker/Dockerfile | Made CMake install step conditional on $TARGETARCH |
| fi | ||
|
|
||
| # Determine system architecture | ||
| readonly ARCH=$(uname -m) |
There was a problem hiding this comment.
[nitpick] Both setup scripts reimplement architecture detection. Consider extracting this into a shared helper or common script to reduce duplication.
Copilot uses AI. Check for mistakes.
| echo "Upgrading CMake for ARM64 build..." | ||
| ${ROOT}/scripts/setup/setup-cmake.sh | ||
| else | ||
| echo "Using default CMake for AMD64 build..." |
There was a problem hiding this comment.
[nitpick] Hardcoding "AMD64" may confuse readers since $ARCH is reported as "x86_64"; consider echoing $ARCH or mapping it to a friendly name for consistency.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
1 participant
No description provided.