Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing an eox-map DOM element to for property #1107

Merged
merged 8 commits into from
Jul 22, 2024

Conversation

spectrachrome
Copy link
Member

@spectrachrome spectrachrome commented Jul 18, 2024

Implemented changes

Enables the Layer Control to take both string selectors and HTML elements in its for attribute thanks to Silvester's new getElement function.

Checklist before requesting a review

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit fbd93b4
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/669e6ae273c23b00081049e3
😎 Deploy Preview https://deploy-preview-1107--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@spectrachrome spectrachrome changed the title Layercontrol/feature/agnostic for Element and selector agnostic for attribute Jul 18, 2024
@spectrachrome spectrachrome changed the title Element and selector agnostic for attribute Element-selector agnostic for attribute Jul 22, 2024
@spectrachrome spectrachrome changed the title Element-selector agnostic for attribute refactor: make for attribute agnostic to selectors and HTML elements Jul 22, 2024
@spectrachrome spectrachrome marked this pull request as ready for review July 22, 2024 13:47
@silvester-pari silvester-pari changed the title refactor: make for attribute agnostic to selectors and HTML elements feat: allow passing an eox-map DOM element to for property Jul 22, 2024
@silvester-pari silvester-pari merged commit 1947f7f into main Jul 22, 2024
7 checks passed
@silvester-pari silvester-pari deleted the layercontrol/feature/agnostic-for branch July 22, 2024 15:02
@silvester-pari silvester-pari linked an issue Jul 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't find the map when it's inside a shadow DOM
2 participants