-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow passing an eox-map DOM element to for
property
#1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
spectrachrome
changed the title
Layercontrol/feature/agnostic for
Element and selector agnostic Jul 18, 2024
for
attribute
spectrachrome
changed the title
Element and selector agnostic
Element-selector agnostic Jul 22, 2024
for
attributefor
attribute
spectrachrome
changed the title
Element-selector agnostic
refactor: make Jul 22, 2024
for
attributefor
attribute agnostic to selectors and HTML elements
silvester-pari
approved these changes
Jul 22, 2024
silvester-pari
changed the title
refactor: make
feat: allow passing an eox-map DOM element to Jul 22, 2024
for
attribute agnostic to selectors and HTML elementsfor
property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
Enables the Layer Control to take both string selectors and HTML elements in its
for
attribute thanks to Silvester's newgetElement
function.Checklist before requesting a review