Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find the map when it's inside a shadow DOM #1089

Closed
A-Behairi opened this issue Jul 11, 2024 · 2 comments · Fixed by #1107
Closed

Can't find the map when it's inside a shadow DOM #1089

A-Behairi opened this issue Jul 11, 2024 · 2 comments · Fixed by #1107

Comments

@A-Behairi
Copy link
Collaborator

A-Behairi commented Jul 11, 2024

In the case of the map element living inside a Shadow DOM; passing the map selector as a string in the for property is not possible.

I suggest having the option to support passing a function or having a property that can take the shadow root host element and select the map from inside of it.

for example:

for: {
 map: 'eox-map',
 shadowElement: 'eo-dash'
}
@santilland
Copy link
Member

As we discussed, i think @silvester-pari said as solution we could pass the element directly as for mirroring the solution we do for other eox-elements

@silvester-pari
Copy link
Collaborator

Kinda like in the openlayers map, where the target can be HTMLElement | string | undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants