Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Prefer BUILD_STATIC_LIBS over NSTATIC #521

Merged
merged 23 commits into from
Nov 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f8a4623
CMake: Prefer BUILD_STATIC_LIBS over NSTATIC
mmuetzel Nov 17, 2023
b4b3e7e
SuiteSparse_config: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
d8bcbfc
Mongoose: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
06c4dec
AMD: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
263c117
BTF: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
2ca6eac
CAMD: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
1df5d47
CCOLAMD: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
a82b0fd
COLAMD: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
9453856
CHOLMOD: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
e7082e7
CXSparse: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
c2a133d
LDL: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
2c0b626
KLU: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
eb2cdf5
UMFPACK: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
ae33064
ParU: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
1e4cf3a
RBio: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
fa28a5e
SPQR: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
eeb143a
SPEX: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
11272d9
GraphBLAS: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
0af20b6
LAGraph: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
1238be4
CSparse: Use `BUILD_STATIC_LIBS` instead of `NSTATIC`.
mmuetzel Nov 17, 2023
600a30e
root: Avoid using `NSTATIC`
mmuetzel Nov 17, 2023
aa613b3
SuiteSparsePolicy.cmake: Don't set `NSTATIC`.
mmuetzel Nov 18, 2023
c5efc57
README.md: Document `BUILD_STATIC_LIBS`. No longer mention `NSTATIC`.
mmuetzel Nov 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions AMD/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ target_include_directories ( AMD
# static amd library properties
#-------------------------------------------------------------------------------

if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
add_library ( AMD_static STATIC ${AMD_SOURCES} )
set_target_properties ( AMD_static PROPERTIES
C_STANDARD 11
Expand All @@ -126,7 +126,7 @@ endif ( )
target_link_libraries ( AMD PRIVATE SuiteSparse::SuiteSparseConfig )
target_include_directories ( AMD PUBLIC
"$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES>" )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
if ( TARGET SuiteSparse::SuiteSparseConfig_static )
target_link_libraries ( AMD_static PUBLIC SuiteSparse::SuiteSparseConfig_static )
else ( )
Expand All @@ -137,7 +137,7 @@ endif ( )
# libm:
if ( NOT WIN32 )
target_link_libraries ( AMD PRIVATE m )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
set ( AMD_STATIC_LIBS "${AMD_STATIC_LIBS} -lm" )
target_link_libraries ( AMD_static PUBLIC m )
endif ( )
Expand All @@ -155,7 +155,7 @@ install ( TARGETS AMD
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
RUNTIME DESTINATION ${SUITESPARSE_BINDIR}
PUBLIC_HEADER DESTINATION ${SUITESPARSE_INCLUDEDIR} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
install ( TARGETS AMD_static
EXPORT AMDTargets
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
Expand Down
8 changes: 4 additions & 4 deletions BTF/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ target_include_directories ( BTF
# static btf library properties
#-------------------------------------------------------------------------------

if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
add_library ( BTF_static STATIC ${BTF_SOURCES} )

set_target_properties ( BTF_static PROPERTIES
Expand All @@ -116,15 +116,15 @@ endif ( )
# SuiteSparseConfig:
target_include_directories ( BTF PUBLIC
"$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES>" )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
target_include_directories ( BTF_static PUBLIC
"$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES>" )
endif ( )

# libm:
if ( NOT WIN32 )
target_link_libraries ( BTF PRIVATE m )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
set ( BTF_STATIC_LIBS "${BTF_STATIC_LIBS} -lm" )
target_link_libraries ( BTF_static PUBLIC m )
endif ( )
Expand All @@ -142,7 +142,7 @@ install ( TARGETS BTF
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
RUNTIME DESTINATION ${SUITESPARSE_BINDIR}
PUBLIC_HEADER DESTINATION ${SUITESPARSE_INCLUDEDIR} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
install ( TARGETS BTF_static
EXPORT BTFTargets
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
Expand Down
8 changes: 4 additions & 4 deletions CAMD/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ target_include_directories ( CAMD
# static camd library properties
#-------------------------------------------------------------------------------

if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
add_library ( CAMD_static STATIC ${CAMD_SOURCES} )

set_target_properties ( CAMD_static PROPERTIES
Expand All @@ -119,7 +119,7 @@ endif ( )
target_link_libraries ( CAMD PRIVATE SuiteSparse::SuiteSparseConfig )
target_include_directories ( CAMD PUBLIC
"$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES>" )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
if ( TARGET SuiteSparse::SuiteSparseConfig_static )
target_link_libraries ( CAMD_static PUBLIC SuiteSparse::SuiteSparseConfig_static )
else ( )
Expand All @@ -130,7 +130,7 @@ endif ( )
# libm:
if ( NOT WIN32 )
target_link_libraries ( CAMD PRIVATE m )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
set ( CAMD_STATIC_LIBS "${CAMD_STATIC_LIBS} -lm" )
target_link_libraries ( CAMD_static PUBLIC m )
endif ( )
Expand All @@ -148,7 +148,7 @@ install ( TARGETS CAMD
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
RUNTIME DESTINATION ${SUITESPARSE_BINDIR}
PUBLIC_HEADER DESTINATION ${SUITESPARSE_INCLUDEDIR} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
install ( TARGETS CAMD_static
EXPORT CAMDTargets
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
Expand Down
8 changes: 4 additions & 4 deletions CCOLAMD/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ target_include_directories ( CCOLAMD
# static ccolamd library properties
#-------------------------------------------------------------------------------

if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
add_library ( CCOLAMD_static STATIC ${CCOLAMD_SOURCES} )

set_target_properties ( CCOLAMD_static PROPERTIES
Expand All @@ -116,7 +116,7 @@ endif ( )
target_link_libraries ( CCOLAMD PRIVATE SuiteSparse::SuiteSparseConfig )
target_include_directories ( CCOLAMD PUBLIC
"$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES>" )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
if ( TARGET SuiteSparse::SuiteSparseConfig_static )
target_link_libraries ( CCOLAMD_static PUBLIC SuiteSparse::SuiteSparseConfig_static )
else ( )
Expand All @@ -127,7 +127,7 @@ endif ( )
# libm:
if ( NOT WIN32 )
target_link_libraries ( CCOLAMD PRIVATE m )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
set ( CCOLAMD_STATIC_LIBS "${CCOLAMD_STATIC_LIBS} -lm" )
target_link_libraries ( CCOLAMD_static PUBLIC m )
endif ( )
Expand All @@ -145,7 +145,7 @@ install ( TARGETS CCOLAMD
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
RUNTIME DESTINATION ${SUITESPARSE_BINDIR}
PUBLIC_HEADER DESTINATION ${SUITESPARSE_INCLUDEDIR} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
install ( TARGETS CCOLAMD_static
EXPORT CCOLAMDTargets
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
Expand Down
28 changes: 14 additions & 14 deletions CHOLMOD/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ target_include_directories ( CHOLMOD
# static cholmod library properties
#-------------------------------------------------------------------------------

if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
add_library ( CHOLMOD_static STATIC ${CHOLMOD_SOURCES} )

set_target_properties ( CHOLMOD_static PROPERTIES
Expand Down Expand Up @@ -357,7 +357,7 @@ endif ( )
target_link_libraries ( CHOLMOD PRIVATE SuiteSparse::SuiteSparseConfig )
target_include_directories ( CHOLMOD PUBLIC
"$<TARGET_PROPERTY:SuiteSparse::SuiteSparseConfig,INTERFACE_INCLUDE_DIRECTORIES>" )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
if ( TARGET SuiteSparse::SuiteSparseConfig_static )
target_link_libraries ( CHOLMOD_static PUBLIC SuiteSparse::SuiteSparseConfig_static )
else ( )
Expand All @@ -371,7 +371,7 @@ if ( OPENMP_FOUND )
message ( STATUS "OpenMP C include: ${OpenMP_C_INCLUDE_DIRS} ")
message ( STATUS "OpenMP C flags: ${OpenMP_C_FLAGS} ")
target_link_libraries ( CHOLMOD PRIVATE ${OpenMP_C_LIBRARIES} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
target_link_libraries ( CHOLMOD_static PUBLIC ${OpenMP_C_LIBRARIES} )
list ( APPEND CHOLMOD_STATIC_LIBS ${OpenMP_C_LIBRARIES} )
endif ( )
Expand All @@ -388,7 +388,7 @@ endif ( )
# libm:
if ( NOT WIN32 )
target_link_libraries ( CHOLMOD PRIVATE m )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
list ( APPEND CHOLMOD_STATIC_LIBS "m" )
target_link_libraries ( CHOLMOD_static PUBLIC m )
endif ( )
Expand All @@ -397,7 +397,7 @@ endif ( )

# AMD:
target_link_libraries ( CHOLMOD PRIVATE SuiteSparse::AMD )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
if ( TARGET SuiteSparse::AMD_static )
target_link_libraries ( CHOLMOD_static PUBLIC SuiteSparse::AMD_static )
else ( )
Expand All @@ -407,7 +407,7 @@ endif ( )

# COLAMD:
target_link_libraries ( CHOLMOD PRIVATE SuiteSparse::COLAMD )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
if ( TARGET SuiteSparse::COLAMD_static )
target_link_libraries ( CHOLMOD_static PUBLIC SuiteSparse::COLAMD_static )
else ( )
Expand All @@ -422,7 +422,7 @@ if ( NOT NSUPERNODAL )
message ( STATUS "LAPACK include: ${LAPACK_INCLUDE_DIRS} ")
message ( STATUS "LAPACK linker flags: ${LAPACK_LINKER_FLAGS} ")
target_link_libraries ( CHOLMOD PRIVATE ${LAPACK_LIBRARIES} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
list ( APPEND CHOLMOD_STATIC_LIBS ${LAPACK_LIBRARIES} )
target_link_libraries ( CHOLMOD_static PUBLIC ${LAPACK_LIBRARIES} )
endif ( )
Expand All @@ -433,7 +433,7 @@ if ( NOT NSUPERNODAL )
message ( STATUS "BLAS include: ${BLAS_INCLUDE_DIRS} ")
message ( STATUS "BLAS linker flags: ${BLAS_LINKER_FLAGS} ")
target_link_libraries ( CHOLMOD PRIVATE ${BLAS_LIBRARIES} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
list ( APPEND CHOLMOD_STATIC_LIBS ${BLAS_LIBRARIES} )
target_link_libraries ( CHOLMOD_static PUBLIC ${BLAS_LIBRARIES} )
endif ( )
Expand All @@ -443,7 +443,7 @@ endif ( )
# CAMD and CCOLAMD:
if ( NOT NCAMD )
target_link_libraries ( CHOLMOD PRIVATE SuiteSparse::CAMD )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
set ( CHOLMOD_STATIC_MODULES "${CHOLMOD_STATIC_MODULES} CAMD" )
if ( TARGET SuiteSparse::CAMD_static )
target_link_libraries ( CHOLMOD_static PUBLIC SuiteSparse::CAMD_static )
Expand All @@ -453,7 +453,7 @@ if ( NOT NCAMD )
endif ( )

target_link_libraries ( CHOLMOD PRIVATE SuiteSparse::CCOLAMD )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
set ( CHOLMOD_STATIC_MODULES "${CHOLMOD_STATIC_MODULES} CCOLAMD" )
if ( TARGET SuiteSparse::CCOLAMD_static )
target_link_libraries ( CHOLMOD_static PUBLIC SuiteSparse::CCOLAMD_static )
Expand All @@ -476,15 +476,15 @@ if ( SUITESPARSE_CUDA )
set ( CHOLMOD_STATIC_MODULES "${CHOLMOD_STATIC_MODULES} CHOLMOD_CUDA" )
set ( CHOLMOD_CFLAGS "${CHOLMOD_CFLAGS} -DSUITESPARSE_CUDA" )
target_compile_definitions ( CHOLMOD PUBLIC "SUITESPARSE_CUDA" )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
target_link_libraries ( CHOLMOD_static PUBLIC CHOLMOD_CUDA_static ${CUDA_LIBRARIES} )
target_compile_definitions ( CHOLMOD_static PUBLIC "SUITESPARSE_CUDA" )
endif ( )
target_link_libraries ( CHOLMOD PRIVATE CUDA::nvrtc CUDA::cudart_static
CUDA::nvToolsExt CUDA::cublas )
target_include_directories ( CHOLMOD INTERFACE
$<TARGET_PROPERTY:CUDA::cublas,INTERFACE_INCLUDE_DIRECTORIES> )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
target_link_libraries ( CHOLMOD_static PUBLIC CUDA::nvrtc CUDA::cudart_static
CUDA::nvToolsExt CUDA::cublas )
endif ( )
Expand All @@ -496,7 +496,7 @@ if ( SUITESPARSE_CUDA )

if ( NOT HAVE_COMPAR_FN_T )
target_compile_definitions ( CHOLMOD PRIVATE NCOMPAR_FN_T )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
target_compile_definitions ( CHOLMOD_static PRIVATE NCOMPAR_FN_T )
endif ( )
endif ( )
Expand All @@ -515,7 +515,7 @@ install ( TARGETS CHOLMOD
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
RUNTIME DESTINATION ${SUITESPARSE_BINDIR}
PUBLIC_HEADER DESTINATION ${SUITESPARSE_INCLUDEDIR} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
install ( TARGETS CHOLMOD_static
EXPORT CHOLMODTargets
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
Expand Down
8 changes: 4 additions & 4 deletions CHOLMOD/GPU/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ set_target_properties ( CHOLMOD_CUDA PROPERTIES
OUTPUT_NAME cholmod_cuda
SOVERSION ${CHOLMOD_VERSION_MAJOR} )

if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
add_library ( CHOLMOD_CUDA_static STATIC ${CHOLMOD_CUDA_SOURCES} )

set_target_properties ( CHOLMOD_CUDA_static PROPERTIES
Expand Down Expand Up @@ -75,7 +75,7 @@ set_target_properties ( CHOLMOD_CUDA PROPERTIES POSITION_INDEPENDENT_CODE ON )
set_target_properties ( CHOLMOD_CUDA PROPERTIES CUDA_SEPARABLE_COMPILATION ON )
target_compile_definitions ( CHOLMOD_CUDA PUBLIC "SUITESPARSE_CUDA" )

if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
target_include_directories ( CHOLMOD_CUDA_static PRIVATE
${CUDAToolkit_INCLUDE_DIRS}
${CHOLMOD_CUDA_INCLUDES} )
Expand All @@ -86,7 +86,7 @@ endif ( )

target_link_libraries ( CHOLMOD_CUDA PRIVATE CUDA::nvrtc CUDA::cudart_static
CUDA::nvToolsExt CUDA::cublas )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
target_link_libraries ( CHOLMOD_CUDA_static PUBLIC CUDA::nvrtc CUDA::cudart_static
CUDA::nvToolsExt CUDA::cublas )
endif ( )
Expand All @@ -103,7 +103,7 @@ install ( TARGETS CHOLMOD_CUDA
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
RUNTIME DESTINATION ${SUITESPARSE_BINDIR}
PUBLIC_HEADER DESTINATION ${SUITESPARSE_INCLUDEDIR} )
if ( NOT NSTATIC )
if ( BUILD_STATIC_LIBS )
install ( TARGETS CHOLMOD_CUDA_static
EXPORT CHOLMOD_CUDATargets
ARCHIVE DESTINATION ${SUITESPARSE_LIBDIR}
Expand Down
Loading