CMake: Prefer BUILD_STATIC_LIBS over NSTATIC #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "default" CMake flag to select whether static or dynamic libraries should be built is `BUILD_SHARED_LIBS`. CMake projects that support building shared and static libraries at the same time, use `BUILD_SHARED_LIBS` and `BUILD_STATIC_LIBS` by default. As a first step towards a "more default" setup, add support for `BUILD_STATIC_LIBS` for selecting whether static libraries should be build. Keep support for `NSTATIC` for backwards compatibility. But `BUILD_STATIC_LIBS` takes precedence over `NSTATIC` if both are set by a user.
It is no longer needed.
DrTimothyAldenDavis
merged commit b1ffcd6
into
DrTimothyAldenDavis:dev2
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "default" CMake flag to select whether static or dynamic libraries should be built is
BUILD_SHARED_LIBS. CMake projects that support building shared and static libraries at the same time, useBUILD_SHARED_LIBSandBUILD_STATIC_LIBSby default.As a first step towards a "more default" setup, add support for
BUILD_STATIC_LIBSfor selecting whether static libraries should be build.Keep support for
NSTATICfor backwards compatibility. ButBUILD_STATIC_LIBStakes precedence overNSTATICif both are set by a user.This is in preparation for #424.