-
Notifications
You must be signed in to change notification settings - Fork 18
feat!: enable non-blocking DNS for reqwest #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
a8a92e2
b2c627b
0dca02a
cab0960
19a1ec9
71aba36
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,9 +146,16 @@ if ($USE_MSVC) { | |
| $CXX_BRIDGE_LIB, | ||
| # Note: when linking Rust staticlibs from C++, native system libraries that Rust | ||
| # would normally link automatically for Rust binaries must be provided here. | ||
| # | ||
| # `rustls-platform-verifier` uses the Windows certificate APIs (Cert*), which live in Crypt32. | ||
| "ws2_32.lib", "advapi32.lib", "userenv.lib", "ntdll.lib", "bcrypt.lib", "ole32.lib", "crypt32.lib" | ||
| "advapi32.lib", | ||
| "bcrypt.lib", | ||
| # `rustls-platform-verifier` uses the Windows certificate APIs (Cert*), which live in Crypt32 | ||
| "crypt32.lib", | ||
| # `hickory-resolver` uses GetAdaptersAddresses, which lives in iphlpapi. | ||
| "iphlpapi.lib", | ||
| "ntdll.lib", | ||
| "ole32.lib", | ||
| "userenv.lib", | ||
| "ws2_32.lib" | ||
|
Comment on lines
-149
to
+158
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (Note to other reviewers -- same list of libraries reordered, with only |
||
| ) | ||
|
|
||
| # Add extra MSVC libraries if specified | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part I'm not confident at all in -- maybe worth confirming with @gleocadie that this new dll dependency is fine?