Conversation
31fe0f4 to
af8e147
Compare
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results📦
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
==========================================
+ Coverage 70.85% 70.95% +0.10%
==========================================
Files 424 424
Lines 61963 62010 +47
==========================================
+ Hits 43903 43999 +96
+ Misses 18060 18011 -49
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-02-17 22:20:08 Comparing candidate commit 468316b in PR branch Found 7 performance improvements and 9 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:normalization/normalize_service/normalize_service/[empty string]
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
af8e147 to
8354f61
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
8354f61 to
6389231
Compare
ivoanjo
left a comment
There was a problem hiding this comment.
Nice, this was way easier than I was expecting! I've left you a question in PM, otherwise happy to approve :)
6389231 to
3b3f4e0
Compare
3b3f4e0 to
af2d1c7
Compare
af2d1c7 to
0dca02a
Compare
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
What does this PR do?
Motivation
https://github.com/DataDog/dd-source/pull/355564
The non-use of the blocking pool is particularly nice, since it lets us avoid the uncontrolled thread that can break things on forks.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.