-
Notifications
You must be signed in to change notification settings - Fork 1.4k
trace_agent_integration_tests: tentatively fix flakiness
#43627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trace_agent_integration_tests: tentatively fix flakiness
#43627
Conversation
cbd7e5b to
3232a1b
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: cf0c253 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.88 | [-1.08, +4.84] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.88 | [-1.08, +4.84] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.65 | [+0.21, +3.10] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +1.00 | [+0.93, +1.07] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.73 | [+0.59, +0.87] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.58 | [+0.36, +0.80] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.54 | [+0.33, +0.75] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | +0.41 | [+0.32, +0.50] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.27 | [+0.22, +0.33] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.17 | [+0.01, +0.32] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.11 | [-0.12, +0.35] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.06 | [+0.01, +0.11] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.05 | [+0.00, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.34, +0.41] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.11, +0.13] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.00 | [-0.22, +0.22] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.08, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.12, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.08, +0.03] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.39, +0.34] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.04 | [-0.13, +0.04] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.04 | [-0.45, +0.37] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.17 | [-0.22, -0.12] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.50 | [-0.57, -0.44] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
897c9ef to
ab36a84
Compare
The `trace-agent` integration tests have been repeatedly failing on timeouts, for instance: - https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261246921 - https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261237699 - https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261226844 There are at least 2 culprits: 1. rebuilding the `trace-agent` binary from scratch for every test run. When running with the race detector (`-race` flag), each build takes time, 2. module cache contention when building, see #43207 for why. This change implements the TODO at agent.go:94 by: - ceating a temporary directory in `TestMain` (`BuildCachedBinaries`), - building `trace-agent` and `secret-script` binaries once in that directory, with `GOPRIVATE=*` and `GOPROXY=off` to prevent concurrent module cache access, - creating symlinks to the cached binaries in per-test subdirectories, - cleaning up the entire temp directory tree after all tests complete. This is expected to reduce test execution time, especially with race detection enabled, and hopefully preventtimeouts in `TestTraces`.
ab36a84 to
20e8b4b
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
### What does this PR do? Adds `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage` to reduce test timeouts on macOS CI runners. Extracts the isolation logic into reusable helpers in `pkg/util/testutil/gobuild.go` and applies them to existing code in `comp/core/secrets/impl`, `cmd/trace-agent/test`, and `comp/trace/config`. ### Motivation The test still times out occasionally after 3 minutes on macOS Gitlab runners when running with `-p 12 -parallel 12`, despite previous fix (#43207) which added `GOPRIVATE=*` and `GOPROXY=off`. The root cause is that `analysistest.Run` internally runs `go build` commands to verify the Go toolchain works. When multiple tests run concurrently with the same shared `GOCACHE`, they can deadlock in Go's process management layer (see golang/go#59657). ### Changes Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following the same approach as PR #39687 which fixed a similar timeout issue in `comp/core/secrets/impl/fetch_secret_test.go`. Created `pkg/util/testutil/gobuild.go` with two helpers: - `IsolatedGoBuildCmd(cacheDir, output, args...)` for creating `go build -o output` commands with isolated env - `IsolatedGoBuildEnv(cacheDir)` for returning isolated build environment variables Applied these helpers to existing code that had similar patterns. Note: `-mod=vendor` could be factored out in a future change if the problem manifests itself again in other locations. ### Prior art - #39518 - #39687 - #43207 - #43627 ### Describe how you validated your changes - Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`
### What does this PR do? Adds `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage` to reduce test timeouts on macOS CI runners. Extracts the isolation logic into reusable helpers in `pkg/util/testutil/gobuild.go` and applies them to existing code in `comp/core/secrets/impl`, `cmd/trace-agent/test`, and `comp/trace/config`. ### Motivation The test still times out occasionally after 3 minutes on macOS Gitlab runners when running with `-p 12 -parallel 12`, despite previous fix (#43207) which added `GOPRIVATE=*` and `GOPROXY=off`. The root cause is that `analysistest.Run` internally runs `go build` commands to verify the Go toolchain works. When multiple tests run concurrently with the same shared `GOCACHE`, they can deadlock in Go's process management layer (see golang/go#59657). ### Changes Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following the same approach as PR #39687 which fixed a similar timeout issue in `comp/core/secrets/impl/fetch_secret_test.go`. Created `pkg/util/testutil/gobuild.go` with two helpers: - `IsolatedGoBuildCmd(cacheDir, output, args...)` for creating `go build -o output` commands with isolated env - `IsolatedGoBuildEnv(cacheDir)` for returning isolated build environment variables Applied these helpers to existing code that had similar patterns. Note: `-mod=vendor` could be factored out in a future change if the problem manifests itself again in other locations. ### Prior art - #39518 - #39687 - #43207 - #43627 ### Describe how you validated your changes - Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`
### What does this PR do? Adds `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage` to reduce test timeouts on macOS CI runners. Extracts the isolation logic into reusable helpers in `pkg/util/testutil/gobuild.go` and applies them to existing code in `comp/core/secrets/impl`, `cmd/trace-agent/test`, and `comp/trace/config`. ### Motivation The test still times out occasionally after 3 minutes on macOS Gitlab runners when running with `-p 12 -parallel 12`, despite previous fix (#43207) which added `GOPRIVATE=*` and `GOPROXY=off`. The root cause is that `analysistest.Run` internally runs `go build` commands to verify the Go toolchain works. When multiple tests run concurrently with the same shared `GOCACHE`, they can deadlock in Go's process management layer (see golang/go#59657). ### Changes Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following the same approach as PR #39687 which fixed a similar timeout issue in `comp/core/secrets/impl/fetch_secret_test.go`. Created `pkg/util/testutil/gobuild.go` with two helpers: - `IsolatedGoBuildCmd(cacheDir, output, args...)` for creating `go build -o output` commands with isolated env - `IsolatedGoBuildEnv(cacheDir)` for returning isolated build environment variables Applied these helpers to existing code that had similar patterns. Note: `-mod=vendor` could be factored out in a future change if the problem manifests itself again in other locations. ### Prior art - #39518 - #39687 - #43207 - #43627 ### Describe how you validated your changes - Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`
…ond `pkgconfigusage` (#43773) ### What does this PR do? Add `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage` to reduce test timeouts on macOS CI runners. Extract the isolation logic into reusable helpers in `pkg/util/testutil/gobuild.go` and applies them to existing test code in: - `cmd/trace-agent/test/agent.go`, - `comp/core/secrets/impl/fetch_secret_test.go`, - `comp/trace/config/config_test.go`, - `pkg/linters/components/pkgconfigusage/pkgconfigusage_test.go`. ### Motivation The test still times out occasionally ([example in `main`](http://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1267508733/viewer#L2040)) after 3 minutes on macOS Gitlab runners when running with `-p 12 -parallel 12`, despite previous tentative fix (#43207) which added `GOPRIVATE=*` and `GOPROXY=off`. `analysistest.Run` internally runs `go build` commands to verify the Go toolchain works. When multiple tests run concurrently with the same shared `GOCACHE`, they can deadlock in Go's process management layer (see golang/go#59657). ### Changes Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following the same approach as PR #39687 which fixed a similar timeout issue in `comp/core/secrets/impl/fetch_secret_test.go`. Created `pkg/util/testutil/gobuild.go` with two helpers: - `IsolatedGoBuildCmd(cacheDir, output, args...)` for creating `go build -o output` commands with isolated env, - `IsolatedGoBuildEnv(cacheDir)` for returning isolated build environment variables. Applied these helpers to existing code that had similar patterns. ### Describe how you validated your changes Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`. ### Additional Notes Prior art include: - #39518 - #39687 - #43207 - #43627 💡 `-mod=vendor` could be also factored out through a future PR should the problem manifest itself again after the present change is merged. Co-authored-by: regis.desgroppes <[email protected]>
What does this PR do?
The present change is expected to reduce test execution time, especially with race detection enabled, and hopefully prevent timeouts in
TestTracesand siblings.This change implements the
TODOinagent.goby:trace-agentandsecret-scriptbinaries once in that directory, withGOPRIVATE=*andGOPROXY=offto prevent concurrent module cache access,Motivation
The
trace-agentintegration tests have been repeatedly failing on timeouts, for instance:There are at least 2 culprits:
trace-agentbinary from scratch for every test run. When running with the race detector (-raceflag), each build takes time,tests_macos_gitlab_amd64: tentatively fix flakyTestAll#43207 for why.