Skip to content

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Nov 28, 2025

What does this PR do?

The present change is expected to reduce test execution time, especially with race detection enabled, and hopefully prevent timeouts in TestTraces and siblings.

This change implements the TODO in agent.go by:

  • creating a top-level temporary directory,
  • building trace-agent and secret-script binaries once in that directory, with GOPRIVATE=* and GOPROXY=off to prevent concurrent module cache access,
  • creating symlinks to the cached binaries in per-test subdirectories,
  • cleaning up the entire temp directory tree after all tests complete.

Motivation

The trace-agent integration tests have been repeatedly failing on timeouts, for instance:

There are at least 2 culprits:

  1. rebuilding the trace-agent binary from scratch for every test run. When running with the race detector (-race flag), each build takes time,
  2. module cache contention when building, see tests_macos_gitlab_amd64: tentatively fix flaky TestAll #43207 for why.

@rdesgroppes rdesgroppes added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 28, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 28, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/cache-trace-agent-test-binaries branch from cbd7e5b to 3232a1b Compare November 28, 2025 13:11
@rdesgroppes rdesgroppes marked this pull request as ready for review November 28, 2025 13:24
@rdesgroppes rdesgroppes requested a review from a team as a code owner November 28, 2025 13:24
@rdesgroppes rdesgroppes added the ask-review Ask required teams to review this PR label Nov 28, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 28, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor fcb5852

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 DataNotFound $${705.02}$$ < $${717.44}$$ DataNotFound $${172.92}$$ < $${177.37}$$
agent_deb_amd64_fips DataNotFound $${699.86}$$ < $${711.66}$$ DataNotFound $${171.67}$$ < $${174.84}$$
agent_heroku_amd64 DataNotFound $${326.33}$$ < $${337.57}$$ DataNotFound $${87.34}$$ < $${90.78}$$
agent_msi DataNotFound $${981.55}$$ < $${1015.38}$$ DataNotFound $${142.05}$$ < $${149.42}$$
agent_rpm_amd64 DataNotFound $${705.01}$$ < $${717.41}$$ DataNotFound $${175.91}$$ < $${178.01}$$
agent_rpm_amd64_fips DataNotFound $${699.84}$$ < $${711.64}$$ DataNotFound $${174.0}$$ < $${177.26}$$
agent_rpm_arm64 DataNotFound $${690.69}$$ < $${702.19}$$ DataNotFound $${159.73}$$ < $${163.22}$$
agent_rpm_arm64_fips DataNotFound $${686.5}$$ < $${697.6}$$ DataNotFound $${159.06}$$ < $${162.68}$$
agent_suse_amd64 DataNotFound $${705.01}$$ < $${717.41}$$ DataNotFound $${175.91}$$ < $${178.01}$$
agent_suse_amd64_fips DataNotFound $${699.84}$$ < $${711.64}$$ DataNotFound $${174.0}$$ < $${177.26}$$
agent_suse_arm64 DataNotFound $${690.69}$$ < $${702.19}$$ DataNotFound $${159.73}$$ < $${163.22}$$
agent_suse_arm64_fips DataNotFound $${686.5}$$ < $${697.6}$$ DataNotFound $${159.06}$$ < $${162.68}$$
docker_agent_amd64 DataNotFound $${767.36}$$ < $${769.92}$$ DataNotFound $${260.59}$$ < $${261.52}$$
docker_agent_arm64 DataNotFound $${777.3}$$ < $${779.46}$$ DataNotFound $${250.78}$$ < $${251.72}$$
docker_agent_jmx_amd64 DataNotFound $${958.24}$$ < $${960.8}$$ DataNotFound $${329.22}$$ < $${330.15}$$
docker_agent_jmx_arm64 DataNotFound $${956.9}$$ < $${958.93}$$ DataNotFound $${315.41}$$ < $${316.35}$$
docker_cluster_agent_amd64 DataNotFound $${178.85}$$ < $${207.49}$$ DataNotFound $${63.16}$$ < $${70.2}$$
docker_cluster_agent_arm64 DataNotFound $${196.33}$$ < $${223.38}$$ DataNotFound $${59.88}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 DataNotFound $${7.07}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 DataNotFound $${38.58}$$ < $${39.3}$$ DataNotFound $${14.91}$$ < $${15.76}$$
docker_dogstatsd_arm64 DataNotFound $${37.24}$$ < $${37.94}$$ DataNotFound $${14.35}$$ < $${14.83}$$
dogstatsd_deb_amd64 DataNotFound $${29.8}$$ < $${30.53}$$ DataNotFound $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 DataNotFound $${28.31}$$ < $${29.11}$$ DataNotFound $${6.8}$$ < $${7.71}$$
dogstatsd_rpm_amd64 DataNotFound $${29.8}$$ < $${30.53}$$ DataNotFound $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 DataNotFound $${29.8}$$ < $${30.53}$$ DataNotFound $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 DataNotFound $${42.55}$$ < $${43.19}$$ DataNotFound $${11.11}$$ < $${11.98}$$
iot_agent_deb_arm64 DataNotFound $${40.29}$$ < $${40.92}$$ DataNotFound $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf DataNotFound $${40.2}$$ < $${40.86}$$ DataNotFound $${9.69}$$ < $${10.56}$$
iot_agent_rpm_amd64 DataNotFound $${42.56}$$ < $${43.19}$$ DataNotFound $${11.13}$$ < $${12.0}$$
iot_agent_suse_amd64 DataNotFound $${42.56}$$ < $${43.19}$$ DataNotFound $${11.13}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 28, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 02eb9056-b5a2-4213-a016-c32789e1cbd6

Baseline: cf0c253
Comparison: 20e8b4b
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.88 [-1.08, +4.84] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.88 [-1.08, +4.84] 1 Logs
quality_gate_logs % cpu utilization +1.65 [+0.21, +3.10] 1 Logs bounds checks dashboard
ddot_logs memory utilization +1.00 [+0.93, +1.07] 1 Logs
otlp_ingest_metrics memory utilization +0.73 [+0.59, +0.87] 1 Logs
ddot_metrics memory utilization +0.58 [+0.36, +0.80] 1 Logs
quality_gate_metrics_logs memory utilization +0.54 [+0.33, +0.75] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.41 [+0.32, +0.50] 1 Logs
quality_gate_idle_all_features memory utilization +0.27 [+0.22, +0.33] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.17 [+0.01, +0.32] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.11 [-0.12, +0.35] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.06 [+0.01, +0.11] 1 Logs
file_tree memory utilization +0.05 [+0.00, +0.10] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.34, +0.41] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
ddot_metrics_sum_delta memory utilization -0.00 [-0.22, +0.22] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.08, +0.08] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.12, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.08, +0.03] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.39, +0.34] 1 Logs
otlp_ingest_logs memory utilization -0.04 [-0.13, +0.04] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.45, +0.37] 1 Logs
quality_gate_idle memory utilization -0.17 [-0.22, -0.12] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.50 [-0.57, -0.44] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/cache-trace-agent-test-binaries branch 4 times, most recently from 897c9ef to ab36a84 Compare November 29, 2025 00:18
The `trace-agent` integration tests have been repeatedly failing on
timeouts, for instance:
- https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261246921
- https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261237699
- https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261226844

There are at least 2 culprits:
1. rebuilding the `trace-agent` binary from scratch for every test run.
   When running with the race detector (`-race` flag), each build takes
   time,
2. module cache contention when building, see #43207 for why.

This change implements the TODO at agent.go:94 by:
- ceating a temporary directory in `TestMain` (`BuildCachedBinaries`),
- building `trace-agent` and `secret-script` binaries once in that
  directory, with `GOPRIVATE=*` and `GOPROXY=off` to prevent concurrent
  module cache access,
- creating symlinks to the cached binaries in per-test subdirectories,
- cleaning up the entire temp directory tree after all tests complete.

This is expected to reduce test execution time, especially with race
detection enabled, and hopefully preventtimeouts in `TestTraces`.
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/cache-trace-agent-test-binaries branch from ab36a84 to 20e8b4b Compare December 1, 2025 09:13
@rdesgroppes
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 1, 2025

View all feedbacks in Devflow UI.

2025-12-01 10:44:40 UTC ℹ️ Start processing command /merge


2025-12-01 10:44:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 42m (p90).


2025-12-01 11:40:42 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 320050a into main Dec 1, 2025
300 of 301 checks passed
@dd-mergequeue dd-mergequeue bot deleted the regis.desgroppes/cache-trace-agent-test-binaries branch December 1, 2025 11:40
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 1, 2025
rdesgroppes added a commit that referenced this pull request Dec 3, 2025
### What does this PR do?

Adds `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage`
to reduce test timeouts on macOS CI runners.

Extracts the isolation logic into reusable helpers in `pkg/util/testutil/gobuild.go`
and applies them to existing code in `comp/core/secrets/impl`, `cmd/trace-agent/test`,
and `comp/trace/config`.

### Motivation

The test still times out occasionally after 3 minutes on macOS Gitlab runners
when running with `-p 12 -parallel 12`, despite previous fix (#43207) which
added `GOPRIVATE=*` and `GOPROXY=off`.

The root cause is that `analysistest.Run` internally runs `go build` commands
to verify the Go toolchain works. When multiple tests run concurrently with
the same shared `GOCACHE`, they can deadlock in Go's process management layer
(see golang/go#59657).

### Changes

Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following
the same approach as PR #39687 which fixed a similar timeout issue in
`comp/core/secrets/impl/fetch_secret_test.go`.

Created `pkg/util/testutil/gobuild.go` with two helpers:
- `IsolatedGoBuildCmd(cacheDir, output, args...)` for creating `go build -o output` commands with isolated env
- `IsolatedGoBuildEnv(cacheDir)` for returning isolated build environment variables

Applied these helpers to existing code that had similar patterns.

Note: `-mod=vendor` could be factored out in a future change if the problem
manifests itself again in other locations.

### Prior art

- #39518
- #39687
- #43207
- #43627

### Describe how you validated your changes

- Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`
rdesgroppes added a commit that referenced this pull request Dec 3, 2025
### What does this PR do?

Adds `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage`
to reduce test timeouts on macOS CI runners.

Extracts the isolation logic into reusable helpers in `pkg/util/testutil/gobuild.go`
and applies them to existing code in `comp/core/secrets/impl`, `cmd/trace-agent/test`,
and `comp/trace/config`.

### Motivation

The test still times out occasionally after 3 minutes on macOS Gitlab runners
when running with `-p 12 -parallel 12`, despite previous fix (#43207) which
added `GOPRIVATE=*` and `GOPROXY=off`.

The root cause is that `analysistest.Run` internally runs `go build` commands
to verify the Go toolchain works. When multiple tests run concurrently with
the same shared `GOCACHE`, they can deadlock in Go's process management layer
(see golang/go#59657).

### Changes

Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following
the same approach as PR #39687 which fixed a similar timeout issue in
`comp/core/secrets/impl/fetch_secret_test.go`.

Created `pkg/util/testutil/gobuild.go` with two helpers:
- `IsolatedGoBuildCmd(cacheDir, output, args...)` for creating `go build -o output` commands with isolated env
- `IsolatedGoBuildEnv(cacheDir)` for returning isolated build environment variables

Applied these helpers to existing code that had similar patterns.

Note: `-mod=vendor` could be factored out in a future change if the problem
manifests itself again in other locations.

### Prior art

- #39518
- #39687
- #43207
- #43627

### Describe how you validated your changes

- Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`
rdesgroppes added a commit that referenced this pull request Dec 3, 2025
### What does this PR do?

Adds `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage`
to reduce test timeouts on macOS CI runners.

Extracts the isolation logic into reusable helpers in `pkg/util/testutil/gobuild.go`
and applies them to existing code in `comp/core/secrets/impl`, `cmd/trace-agent/test`,
and `comp/trace/config`.

### Motivation

The test still times out occasionally after 3 minutes on macOS Gitlab runners
when running with `-p 12 -parallel 12`, despite previous fix (#43207) which
added `GOPRIVATE=*` and `GOPROXY=off`.

The root cause is that `analysistest.Run` internally runs `go build` commands
to verify the Go toolchain works. When multiple tests run concurrently with
the same shared `GOCACHE`, they can deadlock in Go's process management layer
(see golang/go#59657).

### Changes

Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following
the same approach as PR #39687 which fixed a similar timeout issue in
`comp/core/secrets/impl/fetch_secret_test.go`.

Created `pkg/util/testutil/gobuild.go` with two helpers:
- `IsolatedGoBuildCmd(cacheDir, output, args...)` for creating `go build -o output` commands with isolated env
- `IsolatedGoBuildEnv(cacheDir)` for returning isolated build environment variables

Applied these helpers to existing code that had similar patterns.

Note: `-mod=vendor` could be factored out in a future change if the problem
manifests itself again in other locations.

### Prior art

- #39518
- #39687
- #43207
- #43627

### Describe how you validated your changes

- Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`
dd-mergequeue bot pushed a commit that referenced this pull request Dec 3, 2025
…ond `pkgconfigusage` (#43773)

### What does this PR do?
Add `GOCACHE` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage` to reduce test timeouts on macOS CI runners.

Extract the isolation logic into reusable helpers in `pkg/util/testutil/gobuild.go` and applies them to existing test code in:
- `cmd/trace-agent/test/agent.go`,
- `comp/core/secrets/impl/fetch_secret_test.go`,
- `comp/trace/config/config_test.go`,
- `pkg/linters/components/pkgconfigusage/pkgconfigusage_test.go`.

### Motivation
The test still times out occasionally ([example in `main`](http://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1267508733/viewer#L2040)) after 3 minutes on macOS Gitlab runners when running with `-p 12 -parallel 12`, despite previous tentative fix (#43207) which added `GOPRIVATE=*` and `GOPROXY=off`.

`analysistest.Run` internally runs `go build` commands to verify the Go toolchain works.
When multiple tests run concurrently with the same shared `GOCACHE`, they can deadlock in Go's process management layer (see golang/go#59657).

### Changes
Added per-test isolated `GOCACHE` directory using `t.TempDir()`, following the same approach as PR #39687 which fixed a similar timeout issue in `comp/core/secrets/impl/fetch_secret_test.go`.

Created `pkg/util/testutil/gobuild.go` with two helpers:
- `IsolatedGoBuildCmd(cacheDir, output, args...)` for creating `go build -o output` commands with isolated env,
- `IsolatedGoBuildEnv(cacheDir)` for returning isolated build environment variables.

Applied these helpers to existing code that had similar patterns.

### Describe how you validated your changes
Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`.

### Additional Notes
Prior art include:
- #39518
- #39687
- #43207
- #43627

💡 `-mod=vendor` could be also factored out through a future PR should the problem manifest itself again after the present change is merged.

Co-authored-by: regis.desgroppes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants