tests_macos_gitlab_arm64 flakiness: extend go build isolation beyond pkgconfigusage

[rdesgroppes]

What does this PR do?

Add GOCACHE isolation to TestAll in pkg/linters/components/pkgconfigusage to reduce test timeouts on macOS CI runners.

Extract the isolation logic into reusable helpers in pkg/util/testutil/gobuild.go and applies them to existing test code in:

• cmd/trace-agent/test/agent.go,
• comp/core/secrets/impl/fetch_secret_test.go,
• comp/trace/config/config_test.go,
• pkg/linters/components/pkgconfigusage/pkgconfigusage_test.go.

Motivation

The test still times out occasionally (example in main) after 3 minutes on macOS Gitlab runners when running with -p 12 -parallel 12, despite previous tentative fix (#43207) which added GOPRIVATE=* and GOPROXY=off.

analysistest.Run internally runs go build commands to verify the Go toolchain works.
When multiple tests run concurrently with the same shared GOCACHE, they can deadlock in Go's process management layer (see golang/go#59657).

Changes

Added per-test isolated GOCACHE directory using t.TempDir(), following the same approach as PR #39687 which fixed a similar timeout issue in comp/core/secrets/impl/fetch_secret_test.go.

Created pkg/util/testutil/gobuild.go with two helpers:

• IsolatedGoBuildCmd(cacheDir, output, args...) for creating go build -o output commands with isolated env,
• IsolatedGoBuildEnv(cacheDir) for returning isolated build environment variables.

Applied these helpers to existing code that had similar patterns.

Describe how you validated your changes

Verified locally with go test -v -race -count=20 -parallel 12 -timeout 600s.

Additional Notes

Prior art include:

• Compile secret backend command in a temp build directory #39518
• Set additional env vars to try to fix test #39687
• tests_macos_gitlab_amd64: tentatively fix flaky TestAll #43207
• trace_agent_integration_tests: tentatively fix flakiness #43627

💡 -mod=vendor could be also factored out through a future PR should the problem manifest itself again after the present change is merged.

[dustmop]

LGTM, hoping this finally fixes these issues, seems very possible that it will.

[dustmop]

I do suspect that you're correct that mod=vendor is unnecessary here, especially after seeing the linked issue on golang, as this seems to be caused by a deadlock rather than network accesses. Agreed that we should wait until after we merge and validate before removing it, at which time we should also remove the two lines below which assign Stdout and Stderr, they were only used to debug these failures.

[rdesgroppes]

💯

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7843536

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${705.21}$$ < $${706.32}$$	$${+0}$$	$${172.96}$$ < $${173.81}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${700.06}$$ < $${701.16}$$	$${+0}$$	$${171.7}$$ < $${172.71}$$
✅	agent_heroku_amd64	$${0}$$	$${326.41}$$ < $${327.69}$$	$${-0}$$	$${87.34}$$ < $${88.19}$$
✅	agent_msi	$${0}$$	$${969.43}$$ < $${982.08}$$	$${+0.02}$$	$${141.47}$$ < $${143.01}$$
✅	agent_rpm_amd64	$${+0}$$	$${705.2}$$ < $${706.31}$$	$${+0.05}$$	$${175.99}$$ < $${176.86}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${700.04}$$ < $${701.15}$$	$${+0.02}$$	$${174.01}$$ < $${174.95}$$
✅	agent_rpm_arm64	$${-0}$$	$${690.86}$$ < $${691.67}$$	$${+0.05}$$	$${159.81}$$ < $${160.7}$$
✅	agent_rpm_arm64_fips	$${-0}$$	$${686.68}$$ < $${687.54}$$	$${+0.03}$$	$${159.14}$$ < $${160.1}$$
✅	agent_suse_amd64	$${+0}$$	$${705.2}$$ < $${706.31}$$	$${+0.05}$$	$${175.99}$$ < $${176.86}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${700.04}$$ < $${701.15}$$	$${+0.02}$$	$${174.01}$$ < $${174.95}$$
✅	agent_suse_arm64	$${-0}$$	$${690.86}$$ < $${691.67}$$	$${+0.05}$$	$${159.81}$$ < $${160.7}$$
✅	agent_suse_arm64_fips	$${-0}$$	$${686.68}$$ < $${687.54}$$	$${+0.03}$$	$${159.14}$$ < $${160.1}$$
✅	docker_agent_amd64	$${+0}$$	$${767.54}$$ < $${768.66}$$	$${+0.01}$$	$${260.63}$$ < $${261.52}$$
✅	docker_agent_arm64	$${-0}$$	$${777.48}$$ < $${778.35}$$	$${+0}$$	$${250.81}$$ < $${251.72}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${958.41}$$ < $${959.54}$$	$${+0}$$	$${329.26}$$ < $${330.15}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${957.08}$$ < $${957.95}$$	$${-0}$$	$${315.43}$$ < $${316.35}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${178.88}$$ < $${179.28}$$	$${+0}$$	$${63.17}$$ < $${63.96}$$
✅	docker_cluster_agent_arm64	$${0}$$	$${196.39}$$ < $${196.79}$$	$${+0}$$	$${59.89}$$ < $${60.69}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${+0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${+0}$$	$${38.6}$$ < $${39.3}$$	$${+0}$$	$${14.91}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.3}$$ < $${37.94}$$	$${-0}$$	$${14.36}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${+0}$$	$${7.87}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.33}$$ < $${29.11}$$	$${+0}$$	$${6.8}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${-0}$$	$${7.88}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${-0}$$	$${7.88}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${0}$$	$${42.59}$$ < $${43.19}$$	$${-0}$$	$${11.12}$$ < $${11.98}$$
✅	iot_agent_deb_arm64	$${0}$$	$${40.33}$$ < $${40.92}$$	$${-0}$$	$${9.58}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${40.23}$$ < $${40.86}$$	$${-0}$$	$${9.69}$$ < $${10.56}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${42.59}$$ < $${43.19}$$	$${-0}$$	$${11.14}$$ < $${12.0}$$
✅	iot_agent_suse_amd64	$${0}$$	$${42.59}$$ < $${43.19}$$	$${-0}$$	$${11.14}$$ < $${12.0}$$

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 24466554-4be6-4d8c-9ddd-1b9810afdff5

Baseline: 7843536
Comparison: 7cdc1b6
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-1.83	[-4.76, +1.10]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.03	[-0.42, +2.48]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.66	[+0.45, +0.87]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	+0.37	[+0.18, +0.56]	1	Logs
➖	quality_gate_idle	memory utilization	+0.20	[+0.14, +0.25]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.19	[+0.15, +0.24]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.15	[+0.09, +0.20]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.09	[-0.01, +0.18]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.06	[-0.35, +0.48]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.06	[-0.10, +0.22]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.02, +0.08]	1	Logs
➖	ddot_logs	memory utilization	+0.02	[-0.05, +0.09]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.01	[-0.23, +0.25]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.40, +0.41]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.12, +0.13]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.08, +0.06]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.02	[-0.15, +0.12]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.07	[-0.44, +0.31]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.12	[-0.17, -0.07]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-0.23	[-0.31, -0.15]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.66	[-0.75, -0.58]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.68	[-0.83, -0.54]	1	Logs
➖	ddot_metrics	memory utilization	-0.86	[-1.07, -0.65]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-1.83	[-4.76, +1.10]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[jeremy-hanna]

👍 for agent runtime files

[rdesgroppes]

/merge

[dd-devflow-routing-codex]

View all feedbacks in Devflow UI.

2025-12-03 18:20:06 UTC ℹ️ Start processing command /merge

---

2025-12-03 18:20:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 41m (p90).

---

2025-12-03 18:46:20 UTC ℹ️ MergeQueue: This merge request was merged

[dd-octo-sts]

The backport to 7.73.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.73.x 7.73.x
# Navigate to the new working tree
cd .worktrees/backport-7.73.x
# Create a new branch
git switch --create backport-43773-to-7.73.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf1f332a3b0d5561d5382cfe206305643042de43
# Push it to GitHub
git push --set-upstream origin backport-43773-to-7.73.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.73.x

Then, create a pull request where the base branch is 7.73.x and the compare/head branch is backport-43773-to-7.73.x.

[dd-octo-sts]

The backport to 7.74.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.74.x 7.74.x
# Navigate to the new working tree
cd .worktrees/backport-7.74.x
# Create a new branch
git switch --create backport-43773-to-7.74.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf1f332a3b0d5561d5382cfe206305643042de43
# Push it to GitHub
git push --set-upstream origin backport-43773-to-7.74.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.74.x

Then, create a pull request where the base branch is 7.74.x and the compare/head branch is backport-43773-to-7.74.x.