[CORE-408] Remove feature flag for new workspace creation #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calypsomatic
changed the title
calypsomatic
commented
Mar 28, 2025
| @@ -716,4 +724,25 @@ describe('NewWorkspaceWizard', () => { | |||
| expect(quickCreateTooltip).not.toBeInTheDocument; | |||
| }); | |||
| }); | |||
|
|
|||
| describe('handles the requireEnhancedBucketLogging option', () => { | |||
| it('hides unprotected Gcp billing projects when additional security monitoring is required', async () => { | |||
There was a problem hiding this comment.
This test from NewWorkspaceModal.test.tsx wasn't yet covered here so I've added it (and the helper function above).
calypsomatic
requested review from
samanehsan,
kevinmarete,
pshapiro4broad and
rjohanek
|
kevinmarete
approved these changes
Mar 28, 2025
snf2ye
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-408
Summary of changes:
Removes the feature flag for the new workspace creation wizard. This means ensuring that
NewWorkspaceModal(the old way) is not used anywhere and deleting that file. I also renamed the directory fromNewWorkspaceModaltoNewWorkspaceWizard, so a lot of files were touched updating names as well.Testing strategy