Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN-444] Allow billing project owners to pause cloud environments #5297

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

lucymcnatt
Copy link
Contributor

@lucymcnatt lucymcnatt commented Mar 27, 2025

Jira Ticket: https://broadworkbench.atlassian.net/browse/AN-444

Before:
image

After:
image

Dependencies

broadinstitute/sam#1657

Adds start_stop permissions for billing project owners

Summary of changes:

What

Removes custom permission logic that only allowed resource creators to pause cloud environments. This will allow users to see the option to pause a running cloud env

Why

To minimize costs, billing project owners want to ability to pause running compute resources. This also defers permission checking to Leo, and therefore Sam, which is the source of truth for all permission checks.

Note: Only billing project owners or resource creators can view resources on the cloud environment page

Testing strategy

@lucymcnatt lucymcnatt requested a review from a team as a code owner March 27, 2025 19:49
Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@lucymcnatt lucymcnatt added this pull request to the merge queue Mar 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 28, 2025
@lucymcnatt lucymcnatt added this pull request to the merge queue Mar 31, 2025
Merged via the queue into dev with commit eebb2f9 Mar 31, 2025
11 checks passed
@lucymcnatt lucymcnatt deleted the AN-444-pause-permissions branch March 31, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants