Skip to content

fix(registry): correct RFC 3610 DOI reference #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mehrn0ush wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

fix(registry): correct RFC 3610 DOI reference #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion schema/cryptography-defs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@
},
{
"name": "RFC 3610",
"url": "https://doi.org/10.17487/RFC5116"
"url": "https://doi.org/10.17487/RFC3610"
}
],
"pattern": "AES[-(128|192|256)][-(GCM|CCM)][-{tagLength}][-{ivLength}]",
Expand Down Expand Up @@ -468,6 +468,10 @@
{
"pattern": "ChaCha20-Poly1305",
"primitive": "ae"
},
{
"pattern": "XChaCha20-Poly1305",
"primitive": "ae"
Comment on lines +473 to +474
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of XChaCha20-Poly1305 is not mentioned in the PR description, which states this is a 'Registry-only data-quality fix' for the RFC 3610 DOI. The PR description claims 'No schema or specification behavior changes,' but adding a new cipher variant is a functional change. Either the PR description should be updated to document this addition, or if this change was included unintentionally, it should be moved to a separate PR. Additionally, XChaCha20-Poly1305 should have a standard reference (such as draft-irtf-cfrg-xchacha) similar to how ChaCha20-Poly1305 references RFC8439.

Copilot uses AI. Check for mistakes.
}
]
},
Expand Down