Skip to content

Conversation

@Mehrn0ush
Copy link
Contributor

As discussed in ticket #761, this PR fixes an incorrect standards reference in the Cryptography Registry.

Fixes #761

Details

  • Corrects the RFC 3610 DOI under the AES AEAD variant (previously pointed to RFC 5116).
  • Registry-only data-quality fix.
  • No schema or specification behavior changes.

@Mehrn0ush Mehrn0ush requested a review from a team as a code owner January 5, 2026 17:09
@stevespringett stevespringett added cap: cryptography Capability: Cryptography (CBOM) cap: cryptography-registry Capability: Cryptography Registry labels Jan 8, 2026
@stevespringett
Copy link
Member

@bhess

Copy link
Contributor

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
Please remove the "XChaCha20" entry since it overlaps with your other PR. Other than that, LGTM!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects an incorrect DOI reference in the Cryptography Registry and adds support for the XChaCha20-Poly1305 AEAD cipher variant.

Changes:

  • Fixes the RFC 3610 DOI URL (was incorrectly pointing to RFC5116)
  • Adds XChaCha20-Poly1305 as a new authenticated encryption variant in the ChaCha20 family

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +473 to +474
"pattern": "XChaCha20-Poly1305",
"primitive": "ae"
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of XChaCha20-Poly1305 is not mentioned in the PR description, which states this is a 'Registry-only data-quality fix' for the RFC 3610 DOI. The PR description claims 'No schema or specification behavior changes,' but adding a new cipher variant is a functional change. Either the PR description should be updated to document this addition, or if this change was included unintentionally, it should be moved to a separate PR. Additionally, XChaCha20-Poly1305 should have a standard reference (such as draft-irtf-cfrg-xchacha) similar to how ChaCha20-Poly1305 references RFC8439.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cap: cryptography Capability: Cryptography (CBOM) cap: cryptography-registry Capability: Cryptography Registry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Defect]: RFC 3610 reference in AES registry variant links to wrong DOI

3 participants