-
-
Notifications
You must be signed in to change notification settings - Fork 81
fix(registry): correct RFC 3610 DOI reference #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(registry): correct RFC 3610 DOI reference #762
Conversation
Signed-off-by: Mehrn0ush <[email protected]>
bhess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Please remove the "XChaCha20" entry since it overlaps with your other PR. Other than that, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects an incorrect DOI reference in the Cryptography Registry and adds support for the XChaCha20-Poly1305 AEAD cipher variant.
Changes:
- Fixes the RFC 3610 DOI URL (was incorrectly pointing to RFC5116)
- Adds XChaCha20-Poly1305 as a new authenticated encryption variant in the ChaCha20 family
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "pattern": "XChaCha20-Poly1305", | ||
| "primitive": "ae" |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of XChaCha20-Poly1305 is not mentioned in the PR description, which states this is a 'Registry-only data-quality fix' for the RFC 3610 DOI. The PR description claims 'No schema or specification behavior changes,' but adding a new cipher variant is a functional change. Either the PR description should be updated to document this addition, or if this change was included unintentionally, it should be moved to a separate PR. Additionally, XChaCha20-Poly1305 should have a standard reference (such as draft-irtf-cfrg-xchacha) similar to how ChaCha20-Poly1305 references RFC8439.
As discussed in ticket #761, this PR fixes an incorrect standards reference in the Cryptography Registry.
Fixes #761
Details