Skip to content

fix(registry): remove duplicate BLAKE2b-HMAC variant (#752) #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mehrn0ush wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −5
Open

fix(registry): remove duplicate BLAKE2b-HMAC variant (#752) #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions schema/cryptography-defs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,16 @@
"pattern": "AES[-(128|192|256)][-(GCM|CCM)][-{tagLength}][-{ivLength}]",
"primitive": "ae"
},
{
"standard": [
Copy link
Contributor

@bhess bhess Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this entry to avoid merge conflicts with your other PR introducing AES-GCM-SIV

{
"name": "RFC 8452",
"url": "https://doi.org/10.17487/RFC8452"
}
],
"pattern": "AES[-(128|192|256)]-GCM-SIV[-{tagLength}][-{ivLength}]",
"primitive": "ae"
},
{
"standard": [
{
Comment on lines +344 to 353
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of AES-GCM-SIV variant is not mentioned in the PR description or related issue #752, which specifically states 'Cryptography Registry data only' and focuses on removing the BLAKE2b-HMAC duplicate. This unrelated change should either be removed from this PR or documented in the PR description with justification.

Suggested change
"name": "RFC 8452",
"url": "https://doi.org/10.17487/RFC8452"
}
],
"pattern": "AES[-(128|192|256)]-GCM-SIV[-{tagLength}][-{ivLength}]",
"primitive": "ae"
},
{
"standard": [
{

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -935,11 +945,11 @@
"primitive": "hash"
},
{
"pattern": "BLAKE2b-(160|256|384|512)-HMAC",
"pattern": "BLAKE2s-(160|256)-HMAC",
"primitive": "mac"
}
]
},
},
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace has been added after the closing brace. This should be removed to maintain consistent formatting.

Suggested change
},
},

Copilot uses AI. Check for mistakes.
{
"family": "BLAKE3",
"standard": [
Expand Down Expand Up @@ -1018,11 +1028,11 @@
],
"variant": [
{
"pattern": "TUAC[-MAC]",
"pattern": "TUAK[-MAC]",
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correction from TUAC to TUAK is not mentioned in the PR description or related issue #752, which states 'No schema or specification behavior changes' and focuses on removing the BLAKE2b-HMAC duplicate. This unrelated fix should either be removed from this PR or documented in the PR description.

Copilot uses AI. Check for mistakes.
"primitive": "mac"
},
{
"pattern": "TUAC[-KDF]",
"pattern": "TUAK[-KDF]",
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correction from TUAC to TUAK is not mentioned in the PR description or related issue #752. This unrelated fix should either be removed from this PR or documented in the PR description.

Copilot uses AI. Check for mistakes.
"primitive": "kdf"
}
]
Expand Down Expand Up @@ -1407,7 +1417,7 @@
],
"variant": [
{
"pattern": "bcrypt[-{cost)]",
"pattern": "bcrypt[-{cost}]",
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correction from 'bcrypt[-{cost)]' to 'bcrypt[-{cost}]' (fixing the mismatched parenthesis/brace) is not mentioned in the PR description or related issue #752. This unrelated fix should either be removed from this PR or documented in the PR description.

Copilot uses AI. Check for mistakes.
"primitive": "hash"
}
]
Expand Down