fix(registry): remove duplicate BLAKE2b-HMAC variant (#752) #753
Conversation
|
cc: @bhess |
bhess
left a comment
bhess
left a comment
There was a problem hiding this comment.
Thank you for highlighting this issue, @Mehrn0ush. Please see my inline comment, it seems to be a typo that caused the duplicate.
Signed-off-by: Mehrn0ush <[email protected]>
Mehrn0ush
force-pushed
the
fix/crypto-registry-blake2-dup
branch
from
4e67374 to
f2a2652
Compare
stevespringett
added
the
cap: cryptography-registry
| "primitive": "ae" | ||
| }, | ||
| { | ||
| "standard": [ |
There was a problem hiding this comment.
Please remove this entry to avoid merge conflicts with your other PR introducing AES-GCM-SIV
There was a problem hiding this comment.
Pull request overview
This PR addresses data quality issues in the Cryptography Registry by removing a duplicate BLAKE2b-HMAC variant and correcting several other typos and omissions.
Changes:
- Removed duplicate BLAKE2b-HMAC variant entry by changing it to BLAKE2s-HMAC
- Added missing AES-GCM-SIV variant with RFC 8452 standard reference
- Fixed TUAC typo to TUAK in two pattern definitions
- Fixed bcrypt pattern syntax error (parenthesis to brace)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "name": "RFC 8452", | ||
| "url": "https://doi.org/10.17487/RFC8452" | ||
| } | ||
| ], | ||
| "pattern": "AES[-(128|192|256)]-GCM-SIV[-{tagLength}][-{ivLength}]", | ||
| "primitive": "ae" | ||
| }, | ||
| { | ||
| "standard": [ | ||
| { |
There was a problem hiding this comment.
The addition of AES-GCM-SIV variant is not mentioned in the PR description or related issue #752, which specifically states 'Cryptography Registry data only' and focuses on removing the BLAKE2b-HMAC duplicate. This unrelated change should either be removed from this PR or documented in the PR description with justification.
| "name": "RFC 8452", | |
| "url": "https://doi.org/10.17487/RFC8452" | |
| } | |
| ], | |
| "pattern": "AES[-(128|192|256)]-GCM-SIV[-{tagLength}][-{ivLength}]", | |
| "primitive": "ae" | |
| }, | |
| { | |
| "standard": [ | |
| { |
| "variant": [ | ||
| { | ||
| "pattern": "TUAC[-MAC]", | ||
| "pattern": "TUAK[-MAC]", |
There was a problem hiding this comment.
The correction from TUAC to TUAK is not mentioned in the PR description or related issue #752, which states 'No schema or specification behavior changes' and focuses on removing the BLAKE2b-HMAC duplicate. This unrelated fix should either be removed from this PR or documented in the PR description.
| }, | ||
| { | ||
| "pattern": "TUAC[-KDF]", | ||
| "pattern": "TUAK[-KDF]", |
| "variant": [ | ||
| { | ||
| "pattern": "bcrypt[-{cost)]", | ||
| "pattern": "bcrypt[-{cost}]", |
There was a problem hiding this comment.
The correction from 'bcrypt[-{cost)]' to 'bcrypt[-{cost}]' (fixing the mismatched parenthesis/brace) is not mentioned in the PR description or related issue #752. This unrelated fix should either be removed from this PR or documented in the PR description.
| } | ||
| ] | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Trailing whitespace has been added after the closing brace. This should be removed to maintain consistent formatting.
| }, | |
| }, |
3 participants
As discussed in ticket #752, this PR fixes a data-quality issue in the Cryptography Registry.
Fixes #752
Details
BLAKE2b-(160|256|384|512)-HMACvariant entry (primitive: mac)Scope
schema/cryptography-defs.json)