Let gradle handle resolving included builds! #1732
Merged
+58
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nightm4re94 Could you please check this branch to see if it works for you? Imho this way is better than manual parsing of the build-files... |
malice00
requested review from
setchy and
prabhu
and removed request for
prabhu
|
cc: @nightm4re94 |
malice00
force-pushed
the
fix/gradle_included_builds
branch
from
86cec34 to
05b9c3f
Compare
Oops, that's the user I wanted to ask for a review... Accidentally asked @setchy! Guess it's time for bed, mistakes are being made... 😉 |
This should handle included builds that are deeper than root-level and also handle included builds that are inserted by scripts (expo!) Signed-off-by: Roland Asmann <[email protected]>
malice00
force-pushed
the
fix/gradle_included_builds
branch
from
05b9c3f to
90c042e
Compare
|
This is generally a far superior and more elegant solution for the problem - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle included builds that are deeper than root-level and also handle included builds that are inserted by scripts (expo!)
This replaces #1731