Ignore uncommented lines in gradle build scripts #1731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much! Could you kindly sign the commit by following instructions below? https://github.com/CycloneDX/cdxgen/pull/1731/checks?check_run_id=40593187724 |
prabhu
approved these changes
Apr 15, 2025
|
Sorry I'm late to the party... I had a better idea to solve this: no manual parsing, instead have gradle handle it. I'm actually almost finished with the implementation. I'll open a new PR. 😄 |
|
Superseded by #1732. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #1658 were prone to errors if users had commented-out blocks of build logic in their Gradle scripts, e.g. for toggling composite builds.
The impact and implications have been outlined here.
This PR attempts to skip any lines that start with
//or are surrounded by/* ... */and adds tests for the skipping behaviour.