Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arm] Use a motion profile for controls #81

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[arm] Use a motion profile for controls #81

wants to merge 16 commits into from

Conversation

SturrockPeter
Copy link
Contributor

@SturrockPeter SturrockPeter commented Jul 14, 2024 •
edited by spacey-sooty

Added motion profiling to arm subsystem. untested, still needs constant values
Resolves #58

SturrockPeter and others added 14 commits June 16, 2024 12:28
@SturrockPeter @spacey-sooty @KO13200
Implement WPILog file logging (#41) (#44)
67f150b 
Resolves #15
Closes #39

Co-authored-by: Jade <[email protected]>
Co-authored-by: koz <[email protected]>
@SturrockPeter
added LED patterns to arm states
d776edb
@SturrockPeter
changed LED states to be in intake and shooter subsystems
f6c5cc0
@SturrockPeter
merged with master
38fa8b7
@SturrockPeter @spacey-sooty
added LED patterns to arm states
aa2a63a
@SturrockPeter @spacey-sooty
changed LED states to be in intake and shooter subsystems
c68d3e9
@SturrockPeter
Merge branch 'peter/LEDintegration' of https://github.com/CurtinFRC/2…
4ab616b 
…024-Offseason into peter/ArmPID
@SturrockPeter
began changes to arm subsystem
4f05a4a
@SturrockPeter
added outdated motion profiling to arm, need to update to acceptable …
64554db 
…motion profiling
@SturrockPeter
Merge branch 'master' of https://github.com/CurtinFRC/2024-Offseason …
b324c6b 
…into peter/ArmPID
@SturrockPeter
added motion profiling to arm PID, buildsbut likeley contains redunda…
2f320e9 
…nt or wrong code
@SturrockPeter
Merge branch 'master' of https://github.com/CurtinFRC/2024-Offseason …
a6e3fde 
…into peter/ArmPID
@SturrockPeter
hopefully complete motion profiling, not checked by mentors, motion p…
66e24cb 
…rofiling/pid/feedforeward values not added
@SturrockPeter
organised arm code a little bit
bf76d9d
@SturrockPeter SturrockPeter requested a review from a team as a code owner July 14, 2024 05:59
@spacey-sooty spacey-sooty changed the title Peter/arm pid [arm] Use a motion profile for controls Jul 21, 2024
@spacey-sooty
Copy link
Member

/format

spacey-sooty
spacey-sooty requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arm controls should use a motion profile
2 participants
@SturrockPeter @spacey-sooty