Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LED integration to shooter #72

Merged
merged 18 commits into from
Aug 12, 2024
Merged

add LED integration to shooter #72

merged 18 commits into from
Aug 12, 2024

Conversation

SturrockPeter
Copy link
Contributor

merged LED code with changes to intake and shooter subsystems.

@SturrockPeter SturrockPeter requested a review from a team as a code owner July 7, 2024 03:16
spacey-sooty
spacey-sooty requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialising port should use a Constants field, not sure if you can intialise multiple objects to the same PWM port, and if you can if its safe to do so. This should be checked and fixed if not possible.

src/main/java/frc/robot/subsystems/Shooter.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Shooter.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Shooter.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Shooter.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Shooter.java Outdated Show resolved Hide resolved
@spacey-sooty
Copy link
Member

/format

@spacey-sooty
Copy link
Member

image
rebase this out

spacey-sooty
spacey-sooty requested changes Jul 28, 2024
View reviewed changes
src/main/java/frc/robot/subsystems/LED.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/LED.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/LED.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/LED.java Outdated Show resolved Hide resolved
@spacey-sooty
Copy link
Member

/format

@spacey-sooty spacey-sooty merged commit b0ff1f1 into master Aug 12, 2024
6 checks passed
@spacey-sooty spacey-sooty changed the title LED integration add LED integration to shooter Aug 12, 2024
@spacey-sooty spacey-sooty deleted the peter/LEDintegration branch August 12, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SturrockPeter @spacey-sooty