Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1 teleop bindings #51

Closed
wants to merge 11 commits into from
Closed

Add v1 teleop bindings #51

wants to merge 11 commits into from

Conversation

totallysomeoneyoudontknow
Copy link
Collaborator

@totallysomeoneyoudontknow totallysomeoneyoudontknow commented Jun 22, 2024 •
edited by spacey-sooty

Resolves #25

@totallysomeoneyoudontknow totallysomeoneyoudontknow requested a review from a team as a code owner June 22, 2024 05:04
@spacey-sooty spacey-sooty added the enhancement New feature or request label Jun 22, 2024
@spacey-sooty spacey-sooty changed the title teleop Add v1 teleop bindings Jun 22, 2024
@totallysomeoneyoudontknow
Copy link
Collaborator Author

/format

spacey-sooty
spacey-sooty requested changes Jun 22, 2024
View reviewed changes
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems pretty good, needs more logging but should be fine for v1 overall

src/main/java/frc/robot/autos/OneNote.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/Robot.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Shooter.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/Intake.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/Robot.java Outdated Show resolved Hide resolved
@spacey-sooty spacey-sooty added the needs test on robot This code hasn't been tested on a robot yet label Jun 22, 2024
@spacey-sooty spacey-sooty self-requested a review July 19, 2024 05:07
spacey-sooty
spacey-sooty requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs override

src/main/java/frc/robot/Robot.java Outdated Show resolved Hide resolved
@spacey-sooty
Copy link
Member

/format

@spacey-sooty
Copy link
Member

/format

@spacey-sooty spacey-sooty mentioned this pull request Aug 7, 2024
Merged
@spacey-sooty spacey-sooty deleted the teleop branch August 8, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty requested changes

Assignees

@totallysomeoneyoudontknow totallysomeoneyoudontknow

Labels
enhancement New feature or request needs test on robot This code hasn't been tested on a robot yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use sensors for intaking and passthrough to shooter
2 participants
@totallysomeoneyoudontknow @spacey-sooty