-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for cmcc 12 #12
Conversation
ddde6ac
to
d1a5d46
Compare
d1a5d46
to
4e7ae8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say anything tp pom changes. But if everything works, LGTM besides small remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still one version change in github action missing
480c822
to
9231dca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change:
- Changelog for 2.1.0
- change the version to 2310 in README icon
9231dca
to
0f0e4e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
"@jangaroo/runtime": "^1.0.0" | ||
}, | ||
"devDependencies": { | ||
"@jangaroo/build": "^1.0.0", | ||
"@jangaroo/core": "^1.0.0", | ||
"@jangaroo/publish": "^1.0.0", | ||
"@jangaroo/run": "^1.0.0", | ||
"eslint": "7.27.0", | ||
"rimraf": "^3.0.2" | ||
"@jangaroo/build": "^1.5.0", | ||
"@jangaroo/core": "^1.5.0", | ||
"@jangaroo/publish": "^1.5.0", | ||
"@jangaroo/run": "^1.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aholtkamp While discussing updating cm versions in plugins we came across node, pnpm and jangaroo versions. We want to stay compatible with old cms releases as long as possible and avoid cms release specific maintenance branches.
Quest now is, if the version updates in the package.json are reasonable for you? We left the jangaroo/runtime version unchanged to stay compatible with older studio installations. All the other dependencies should be used to build the plugin artefact internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For runtime only the normal "dependencies" are relevant. So this change looks good to me if we want to avoid having a maintenance branch while still being compatible to older cms releases.
Update libs
tested with master and 2310