Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for cmcc 12 #12

Merged
merged 10 commits into from
Jan 11, 2024
Merged

Prepare for cmcc 12 #12

merged 10 commits into from
Jan 11, 2024

Conversation

uwilken
Copy link
Contributor

@uwilken uwilken commented Jan 5, 2024

Update libs

tested with master and 2310

@uwilken uwilken force-pushed the prepare-for-cmcc-12 branch 3 times, most recently from ddde6ac to d1a5d46 Compare January 8, 2024 14:38
@uwilken uwilken marked this pull request as ready for review January 9, 2024 12:31
@uwilken uwilken requested review from rreich and pitgrap January 9, 2024 12:33
Copy link
Contributor

@pitgrap pitgrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say anything tp pom changes. But if everything works, LGTM besides small remarks.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
Copy link
Contributor

@pitgrap pitgrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still one version change in github action missing

.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@pitgrap pitgrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change:

  • Changelog for 2.1.0
  • change the version to 2310 in README icon

studio-server/pom.xml Outdated Show resolved Hide resolved
studio-server/pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link

@mkleine mkleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uwilken uwilken requested a review from pitgrap January 10, 2024 14:59
Comment on lines 11 to +17
"@jangaroo/runtime": "^1.0.0"
},
"devDependencies": {
"@jangaroo/build": "^1.0.0",
"@jangaroo/core": "^1.0.0",
"@jangaroo/publish": "^1.0.0",
"@jangaroo/run": "^1.0.0",
"eslint": "7.27.0",
"rimraf": "^3.0.2"
"@jangaroo/build": "^1.5.0",
"@jangaroo/core": "^1.5.0",
"@jangaroo/publish": "^1.5.0",
"@jangaroo/run": "^1.5.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aholtkamp While discussing updating cm versions in plugins we came across node, pnpm and jangaroo versions. We want to stay compatible with old cms releases as long as possible and avoid cms release specific maintenance branches.

Quest now is, if the version updates in the package.json are reasonable for you? We left the jangaroo/runtime version unchanged to stay compatible with older studio installations. All the other dependencies should be used to build the plugin artefact internally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For runtime only the normal "dependencies" are relevant. So this change looks good to me if we want to avoid having a maintenance branch while still being compatible to older cms releases.

@uwilken uwilken requested a review from pitgrap January 11, 2024 14:28
@uwilken uwilken merged commit 4514096 into main Jan 11, 2024
@pitgrap pitgrap deleted the prepare-for-cmcc-12 branch January 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants