Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for cmcc 12 #13

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Prepare for cmcc 12 #13

merged 8 commits into from
Jan 11, 2024

Conversation

uwilken
Copy link
Contributor

@uwilken uwilken commented Jan 8, 2024

Update libs

tested with master and 2310

@uwilken uwilken force-pushed the prepare-for-cmcc-12 branch 2 times, most recently from 69118e4 to 1c9bb9a Compare January 9, 2024 11:46
@uwilken uwilken requested review from rreich and pitgrap January 9, 2024 12:35
@uwilken uwilken marked this pull request as ready for review January 9, 2024 12:35
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@uwilken uwilken force-pushed the prepare-for-cmcc-12 branch 2 times, most recently from f57e8a3 to 18f4276 Compare January 10, 2024 07:11
Copy link
Contributor

@pitgrap pitgrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still one version change in github action missing.

Also missing:

  • Changelog for 2.1.0
  • change the version to 2310 in README icon

.github/workflows/build.yml Outdated Show resolved Hide resolved
@uwilken
Copy link
Contributor Author

uwilken commented Jan 10, 2024

  • change the version to 2310 in README icon

Depends on the meaning of the badge. Does it mean the current or the minimum cms version?

@pitgrap
Copy link
Contributor

pitgrap commented Jan 10, 2024

🤷‍♂️

@uwilken uwilken requested a review from mkleine January 10, 2024 12:54
Copy link

@mkleine mkleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uwilken uwilken requested a review from pitgrap January 11, 2024 14:32
@uwilken uwilken merged commit 2b62d83 into main Jan 11, 2024
@pitgrap pitgrap deleted the prepare-for-cmcc-12 branch January 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants