Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: split helicity module #87

Merged
merged 31 commits into from
Jun 22, 2021
Merged

refactor!: split helicity module #87

merged 31 commits into from
Jun 22, 2021

Conversation

redeboer
Copy link
Member

Split up the helicity module.

Major change: the generate() method is now called formulate() (97e9ce2)

Related to #61

@redeboer
test: wrap test_generate in class
cec8e57
@redeboer
refactor: expose generate_kinematic_variables
eee8fcd
@redeboer
refactor: make generate_wigner_d public
7420d32
@redeboer
refactor: expose generate_clebsch_gordan
0fdf6b8
@redeboer
refactor: make StateWithID public
fef5e16
@redeboer
style: sort kwargs attr.s
8156ef5
@redeboer
refactor: make TwoBodyDecay public
c51c49c
@redeboer
refactor: remove _transition_info module
630e0e6
@redeboer
refactor: move extract_ang_mom to TwoBodyDecay
9e917f9
@redeboer
refactor: improve readability group_transitions
72661c6
@redeboer
chore: remove __validate_float_type
d0dd631
@redeboer
refactor: remove __attempt_int_cast
4d82e86
@redeboer
refactor: switch to sympy.Rational
2153796
@redeboer
refactor: make get_transition_label public
f9d1a27
@redeboer
refactor: extract _state_to_str
65b0193
@redeboer
refactor: rename generate_amplitude_name
e4ce4fc
@redeboer
refactor: rename generate_coefficient_name
3344332
@redeboer
refactor: split helicity module
d52e4b1
@redeboer
refactor: extract assert_two_body_decay
9b6f28d
@redeboer
refactor: move get_helicity_info to decay
a6806d1
@redeboer
style: improve definition order helicity module
a4054b2
@redeboer
refactor: hide name_generator member
ef24922
@redeboer
refactor: simplify __generate_intensity function
b493b34
@redeboer
refactor: rename __register_parameter_couplings
41b6d67
@redeboer
style: remove redundant pylint ignores
132dcbe
@redeboer
refactor!: use formulate for expressions
97e9ce2
@redeboer
test: group_transitions
9fa6acf
@redeboer
style: improve method order helicity.naming
bb5f080
@redeboer
docs: add docstrings to decay module
cbacc18
@redeboer
chore: improve __formulate_dynamics
6d5b443
@redeboer redeboer added the ⚠️ Interface Breaking changes to the API label Jun 22, 2021
@redeboer redeboer added this to the 0.10.0 milestone Jun 22, 2021
@redeboer redeboer self-assigned this Jun 22, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@redeboer redeboer changed the title Public amplitude builder refactor!: split helicity module Jun 22, 2021
@redeboer redeboer enabled auto-merge (squash) June 22, 2021 19:05
@redeboer redeboer disabled auto-merge June 22, 2021 19:07
@redeboer redeboer merged commit 744fe62 into main Jun 22, 2021
@redeboer redeboer deleted the public-amplitude-builder branch June 22, 2021 19:07
@redeboer redeboer mentioned this pull request Mar 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@redeboer redeboer

Labels
⚠️ Interface Breaking changes to the API
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@redeboer