-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize amplitude building functions and make public #61
Comments
This may also make it easier to write some unit tests for the Clebsch-Gordan coefficients. These arguments ampform/src/ampform/helicity.py Lines 707 to 723 in cdec30b
|
Largely addressed through #87, which introduced |
For the documentation (but arguably also for the design), it would be more transparent to build the amplitude model through functions. In particular, the
_generate_partial_decay
methods can be reformulated so that they just produce a product of terms that are relevant to the helicity kinematics only (no dynamics).This issue was motivated by ComPWA/qrules#57, where it would have been nice to explain how the
InteractionProperties
are used to create Clebsch-Gordan coefficients in the canonical basis by pointing to the functions responsible for this in AmpForm:ampform/src/ampform/helicity.py
Lines 584 to 589 in cdec30b
ampform/src/ampform/helicity.py
Lines 671 to 673 in cdec30b
The text was updated successfully, but these errors were encountered: