Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(tests for store) #132

Merged
merged 17 commits into from
Apr 10, 2024
Merged

add(tests for store) #132

merged 17 commits into from
Apr 10, 2024

Conversation

ChrOertlin
Copy link
Contributor

Added

Added tests for the CRUD

tests for
get_filtered_samples
will be a separate pr.
``

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner April 9, 2024 12:52
@ChrOertlin ChrOertlin mentioned this pull request Apr 9, 2024
Merged
6 tasks
@ChrOertlin
Copy link
Contributor Author

Tests for functionality changes:

Samples and sample details can be fetched
image

Users can be created

image

diitaz93
diitaz93 reviewed Apr 10, 2024
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a great job with the coverage of the tests. I think they could be fine-tuned a bit more to be more robust. I am still missing last two modules but you can start addressing my first comments

tests/database/crud/test_create.py Show resolved Hide resolved
tests/database/crud/test_create.py Outdated Show resolved Hide resolved
tests/database/crud/test_create.py Show resolved Hide resolved
tests/database/crud/test_delete.py Outdated Show resolved Hide resolved
tests/database/crud/test_delete.py Outdated Show resolved Hide resolved
tests/database/crud/test_read.py Outdated Show resolved Hide resolved
tests/database/crud/test_read.py Outdated Show resolved Hide resolved
tests/database/crud/test_read.py Outdated Show resolved Hide resolved
tests/database/crud/test_read.py Show resolved Hide resolved
tests/database/crud/test_read.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

diitaz93
diitaz93 reviewed Apr 10, 2024
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing, will check the updates now

tests/database/crud/test_read.py Outdated Show resolved Hide resolved
tests/database/crud/test_read.py Outdated Show resolved Hide resolved
tests/database/crud/test_update.py Outdated Show resolved Hide resolved
tests/database/crud/test_update.py Show resolved Hide resolved
diitaz93
diitaz93 reviewed Apr 10, 2024
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing, will check the updates now

diitaz93
diitaz93 reviewed Apr 10, 2024
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing, will check the updates now

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

diitaz93
diitaz93 approved these changes Apr 10, 2024
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💯

@ChrOertlin ChrOertlin merged commit 653d7a1 into main Apr 10, 2024
5 checks passed
@ChrOertlin ChrOertlin deleted the add-store-tests branch April 10, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean left review comments

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrOertlin @diitaz93 @islean