Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(add filters to crud) #133

Merged
merged 23 commits into from
Apr 15, 2024
Merged

refactor(add filters to crud) #133

merged 23 commits into from
Apr 15, 2024

Conversation

ChrOertlin
Copy link
Contributor

@ChrOertlin ChrOertlin commented Apr 9, 2024 •
edited
Loading

Added

Refactors CRUD functions to use store filters.
based on #132

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner April 9, 2024 13:54
islean
islean approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

genotype_api/database/crud/read.py Outdated Show resolved Hide resolved
genotype_api/database/filters/analysis_filter.py Outdated Show resolved Hide resolved
genotype_api/database/filters/plate_filters.py Outdated Show resolved Hide resolved
genotype_api/database/filters/sample_filters.py Show resolved Hide resolved
genotype_api/database/filters/sample_filters.py Show resolved Hide resolved
genotype_api/database/filters/sample_filters.py Show resolved Hide resolved
genotype_api/database/filters/sample_filters.py Outdated Show resolved Hide resolved
tests/database/filters/test_sample_filters.py Outdated Show resolved Hide resolved
diitaz93
diitaz93 reviewed Apr 11, 2024
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I have some concerns about the filters and the tests

genotype_api/database/filters/sample_filters.py Outdated Show resolved Hide resolved
genotype_api/database/filters/sample_filters.py Show resolved Hide resolved
genotype_api/database/filters/sample_filters.py Show resolved Hide resolved
genotype_api/database/filters/sample_filters.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/database/filters/test_sample_filters.py Outdated Show resolved Hide resolved
tests/database/filters/test_sample_filters.py Outdated Show resolved Hide resolved
tests/database/filters/test_sample_filters.py Outdated Show resolved Hide resolved
tests/database/filters/test_sample_filters.py Outdated Show resolved Hide resolved
tests/database/filters/test_sample_filters.py Outdated Show resolved Hide resolved
diitaz93
diitaz93 approved these changes Apr 11, 2024
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💯

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChrOertlin ChrOertlin merged commit df4146c into main Apr 15, 2024
5 checks passed
@ChrOertlin ChrOertlin deleted the refactor-crud-with-filters branch April 15, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrOertlin @diitaz93 @islean