Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Tomte delivery messages #4172

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Patch Tomte delivery messages #4172

merged 2 commits into from
Jan 30, 2025

Conversation

islean
Copy link
Contributor

@islean islean commented Jan 30, 2025

Description

Tomte uses the same delivery messages as MIP-RNA. Closes #4140.

Added

Changed

Fixed

  • Tomte delivery messages use the same logic as MIP-RNA

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@clingen-sthlm clingen-sthlm temporarily deployed to stage January 30, 2025 15:01 Inactive
@islean
Copy link
Contributor Author

islean commented Jan 30, 2025

Tested with test case sharpbulldog and got the following message. dev-rested-llama-downsampled is the intended dev DNA case:

Hello,

The analysis for case dev-immuneracer-downsampled has been uploaded to the corresponding DNA case(s) on Scout at:

https://scout.scilifelab.se/cust000/dev-restedllama-downsampled

The analysis files are currently being uploaded to your inbox on Caesar:

/home/cust000/inbox/200128

@islean islean marked this pull request as ready for review January 30, 2025 15:04
@islean islean requested a review from a team as a code owner January 30, 2025 15:04
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@islean islean merged commit 49ccde3 into master Jan 30, 2025
10 checks passed
@islean islean deleted the fix-tomte-delivery-messages branch January 30, 2025 15:15
@islean
Copy link
Contributor Author

islean commented Jan 30, 2025

Deployed to the VMs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Tomte delivery message
3 participants