Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order messages #4147

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix order messages #4147

wants to merge 5 commits into from

Conversation

islean
Copy link
Contributor

@islean islean commented Jan 23, 2025

Description

The order messages have changed a bit - namely we do not add new lines between every sample. This PR fixes this

Added

Changed

Fixed

  • New lines for every sample
  • Use case priority name to avoid ints

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@clingen-sthlm clingen-sthlm temporarily deployed to stage January 23, 2025 13:31 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 23, 2025 13:38 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 23, 2025 14:03 Inactive
@islean islean marked this pull request as ready for review January 23, 2025 14:07
@islean islean requested a review from a team as a code owner January 23, 2025 14:07
@clingen-sthlm clingen-sthlm deployed to stage January 23, 2025 14:10 Active
@islean
Copy link
Contributor Author

islean commented Jan 23, 2025

Reference test ticket with this branch deployed: https://support.clinicalgenomics.se/a/tickets/1002193 which contains a mixture of old cases, new cases, new samples and existing samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants