Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch skip rc #4146

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Patch skip rc #4146

merged 4 commits into from
Jan 23, 2025

Conversation

islean
Copy link
Contributor

@islean islean commented Jan 23, 2025

Description

Sometimes skip reception control gets sent as None. This gets converted to False now.

Fixed

  • skip_reception_control gets converted to False if null

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner January 23, 2025 10:16
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@islean
Copy link
Contributor Author

islean commented Jan 23, 2025

Tested on stage:

With patch:
image

Without patch:
image

@Vince-janv Vince-janv merged commit 016d4d7 into master Jan 23, 2025
8 of 10 checks passed
@Vince-janv Vince-janv deleted the patch-skip-reception-control branch January 23, 2025 10:36
@diitaz93
Copy link
Contributor

Deployed to stage:

Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/js.diazboada
done.
Log deploy... done.
cg, version 67.0.2
[js.diazboada@hasta:~] [S_base] $ up

Deployed to production:

Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/js.diazboada
done.
Log deploy... done.
cg, version 67.0.2

@diitaz93
Copy link
Contributor

Deployed to CGVS too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants